Return-path: Received: from mail-fx0-f217.google.com ([209.85.220.217]:43852 "EHLO mail-fx0-f217.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757129AbZINUS2 (ORCPT ); Mon, 14 Sep 2009 16:18:28 -0400 Received: by fxm17 with SMTP id 17so1118654fxm.37 for ; Mon, 14 Sep 2009 13:18:30 -0700 (PDT) Message-ID: <4AAEA510.5060606@lwfinger.net> Date: Mon, 14 Sep 2009 15:18:24 -0500 From: Larry Finger MIME-Version: 1.0 To: Thomas Ilnseher CC: John Linville , Broadcom Wireless , linux-wireless Subject: Re: [PATCH3]Add analog switch support References: <1252956934.4696.23.camel@luzifer.localnet> <69e28c910909141243i5551c87bsfd0c9e767cfa254@mail.gmail.com> <1252958183.4696.25.camel@luzifer.localnet> In-Reply-To: <1252958183.4696.25.camel@luzifer.localnet> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Thomas Ilnseher wrote: > On Mo, 2009-09-14 at 21:43 +0200, Gábor Stefanik wrote: >> Always send patches to John Linville, and CC linux-wireless. > Ok, the last try ... > > As I've seen Gàbor's patch, I noticed that my previous patch was > bullshit. This patch should work: > > (see: http://bcm-v4.sipsolutions.net/802.11/PHY/Anacore) > > Signed-off-by: Thomas Ilnseher > A few points about patch formatting. The subject of the submittal message should be of the form "[PATCH] component: Description". For this one, something like "[PATCH] b43: Add LP PHY analog switch support" would be appropriate. If multiple versions are needed, indicate that a previous one is superceded by [PATCH V2] ..., etc. There should be a line containing --- after the last signed-off-by line. Anything between the beginning of the e-mail and the --- line becomes part of the permanent record if the patch is accepted. Usually quoted material and words like bullshit are avoided. Not always, but usually. Between the --- line and the start of the patch, you can place instructions to Linville regarding the circumstances of the patch and its priority. Such directions are useful to distinguish an improvement that should wait for the next merge period from a bug fix that should be sent upstream ASAP. In this case, the patch fixes a system crash on some platforms and should be applied now. Larry