Return-path: Received: from mga14.intel.com ([143.182.124.37]:18084 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbZHaXL1 (ORCPT ); Mon, 31 Aug 2009 19:11:27 -0400 Subject: Re: hal, rfkill and compat-wireless (Re: [RFC/RFT] rtl8187: Implement rfkill support) From: Inaky Perez-Gonzalez To: "Luis R. Rodriguez" Cc: Marcel Holtmann , Hin-Tak Leung , linux-wireless In-Reply-To: <43e72e890908311605m368f3703vfd8a25694e69072e@mail.gmail.com> References: <3ace41890908261511i3056c049kca82831015ff2aa0@mail.gmail.com> <1251357267.20531.4.camel@johannes.local> <3ace41890908270243i7c1d8ddav322a35c566d2c010@mail.gmail.com> <3ace41890908311143q697898a3mcbc681d3941b45c9@mail.gmail.com> <43e72e890908311154x51fd9481iea5e10fc5515af80@mail.gmail.com> <3ace41890908311215u378951e8j3283037ec6794764@mail.gmail.com> <43e72e890908311225r3b0d80bcqcb3e3e11d81a255e@mail.gmail.com> <1251749600.5165.1.camel@localhost.localdomain> <1251751251.1266.16.camel@localhost.localdomain> <43e72e890908311445q60c703a3ha8ef8e599e3e712@mail.gmail.com> <43e72e890908311605m368f3703vfd8a25694e69072e@mail.gmail.com> Content-Type: text/plain Date: Mon, 31 Aug 2009 16:10:32 -0700 Message-Id: <1251760232.5165.28.camel@localhost.localdomain> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2009-08-31 at 17:05 -0600, Luis R. Rodriguez wrote: > On Mon, Aug 31, 2009 at 2:45 PM, Luis R. Rodriguez wrote: > > On Mon, Aug 31, 2009 at 1:40 PM, Marcel Holtmann wrote: > >> Hi Luis, > >> > >>> > OK not so bad except for: > >>> > > >>> > > kernel/net/wimax/wimax.ko > >>> > > >>> > That's touching another subsystem but we could technically merge wimax > >>> > into compat-wireless if Inaky thinks that's a good idea. the point > >>> > here is to unify anything that uses rfkill for backport usage. > >>> > >>> Oh boy, can of worms > >>> > >>> I have my own compat-wimax already, which already handles things for > >>> backwards compat (many #ifdef hacks to simplify life) and which is > >>> heavily used internally. > >>> > >>> I don't really know how much worth it might be and I know I don't have > >>> resources to support both. > >> > >> for the wireless-compat tree, I would just remove the RFKILL support for > >> WiMAX. It is really not worth to support it. > > > > Works for me, we then still need to address (if we really care) the > > platform stuff. If someone is interested feel free to send patches to > > add those, I figure as long we get down to the latest supported stable > > kernel it should be good. The latest supported stable kernel is always > > on display on kernel,org, today being 2.6.27. > > BTW inaky -- this is actually up to you, are you wiling to live with > no rfkill for compat? I don't really mind -- but it could be a problem for anyone trying to use it. Not that I recommend not being able to switch the radio off :) however, the WiMAX stack has APIs for it too, so at least there is a workaround. But remember, I won't be able to support it at all. -- -- Inaky