Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:60409 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753754AbZJPSbM (ORCPT ); Fri, 16 Oct 2009 14:31:12 -0400 Date: Fri, 16 Oct 2009 14:19:30 -0400 From: "John W. Linville" To: Marcel Holtmann Cc: Zhu Yi , linux-wireless@vger.kernel.org, Samuel Ortiz Subject: Re: [PATCH 03/16] iwmc3200wifi: WPS support Message-ID: <20091016181930.GB6438@tuxdriver.com> References: <1255670340-22565-1-git-send-email-yi.zhu@intel.com> <1255670340-22565-2-git-send-email-yi.zhu@intel.com> <1255670340-22565-3-git-send-email-yi.zhu@intel.com> <1255670340-22565-4-git-send-email-yi.zhu@intel.com> <1255709887.31260.4.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1255709887.31260.4.camel@localhost.localdomain> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Oct 16, 2009 at 06:18:07PM +0200, Marcel Holtmann wrote: > Hi Yi, > > > From: Samuel Ortiz > > > > By setting the WSC profile flag, we now support WPS as an enrollee. > > > > Signed-off-by: Samuel Ortiz > > Signed-off-by: Zhu Yi > > --- > > drivers/net/wireless/iwmc3200wifi/cfg80211.c | 7 +++++++ > > drivers/net/wireless/iwmc3200wifi/commands.h | 3 +++ > > 2 files changed, 10 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/net/wireless/iwmc3200wifi/cfg80211.c b/drivers/net/wireless/iwmc3200wifi/cfg80211.c > > index 0d2e719..a6d2f20 100644 > > --- a/drivers/net/wireless/iwmc3200wifi/cfg80211.c > > +++ b/drivers/net/wireless/iwmc3200wifi/cfg80211.c > > @@ -628,6 +628,13 @@ static int iwm_cfg80211_connect(struct wiphy *wiphy, struct net_device *dev, > > iwm->default_key = sme->key_idx; > > } > > > > + /* WPA and open AUTH type from wpa_s means WPS (a.k.a. WSC) */ > > + if ((iwm->umac_profile->sec.flags & > > + (UMAC_SEC_FLG_WPA_ON_MSK | UMAC_SEC_FLG_RSNA_ON_MSK)) && > > + iwm->umac_profile->sec.auth_type == UMAC_AUTH_TYPE_OPEN) { > > + iwm->umac_profile->sec.flags = UMAC_SEC_FLG_WSC_ON_MSK; > > + } > > + > > I don't wanna be picky, but what coding style are you following here? > The indentation makes no sense and doesn't improve readability. Given the length and complication of the conditions, the indentation seems fine to me. How would you do it? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.