Return-path: Received: from out2.smtp.messagingengine.com ([66.111.4.26]:37556 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997AbZJWO1K (ORCPT ); Fri, 23 Oct 2009 10:27:10 -0400 Message-ID: <4AE1BD3D.3020007@imap.cc> Date: Fri, 23 Oct 2009 16:27:09 +0200 From: Tilman Schmidt MIME-Version: 1.0 To: Johannes Berg CC: Jarek Poplawski , David Miller , hidave.darkstar@gmail.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, linux-wireless@vger.kernel.org, linux-ppp@vger.kernel.org, netdev@vger.kernel.org, paulus@samba.org, isdn4linux , i4ldeveloper , Karsten Keil Subject: Re: NOHZ: local_softirq_pending 08 References: <4AD31213.6020006@imap.cc> <20091015114052.GA9870@ff.dom.local> <4AD76184.6030900@gmail.com> <4ADF5710.4030505@imap.cc> <4AE0ECCE.2020407@imap.cc> <1256304869.12174.20.camel@johannes.local> In-Reply-To: <1256304869.12174.20.camel@johannes.local> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Johannes Berg schrieb: > On Fri, 2009-10-23 at 01:37 +0200, Tilman Schmidt wrote: > >> --- a/drivers/isdn/i4l/isdn_ppp.c >> +++ b/drivers/isdn/i4l/isdn_ppp.c >> @@ -1174,7 +1174,10 @@ isdn_ppp_push_higher(isdn_net_dev * net_dev, isdn_net_local * lp, struct sk_buff >> #endif /* CONFIG_IPPP_FILTER */ >> skb->dev = dev; >> skb_reset_mac_header(skb); >> - netif_rx(skb); >> + if (in_interrupt()) >> + netif_rx(skb); >> + else >> + netif_rx_ni(skb); > > So you've verified that the entire i4l stack can cope with being called > twice on the same CPU, from different contexts? What makes you think so? Better yet, what do you propose? Thanks, Tilman - -- Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFK4b09Q3+did9BuFsRAqBvAKCbRI0iXQEyK3ztxkGHcqpbcceqbACgkagX JF7nYd152ihp2uemIs/cB54= =YOin -----END PGP SIGNATURE-----