Return-path: Received: from mx1.redhat.com ([209.132.183.28]:14207 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752332AbZJWQwx (ORCPT ); Fri, 23 Oct 2009 12:52:53 -0400 Subject: Re: [PATCH 17/19] [RFC, v2] libertas: Kconfig entry for libertas+cfg80211 From: Dan Williams To: Johannes Berg Cc: Holger Schurig , linux-wireless@vger.kernel.org, John Linville In-Reply-To: <1256316535.12174.186.camel@johannes.local> References: <20091022133043.185554096@mail.mn-solutions.de> <20091022133425.317619132@mail.mn-solutions.de> <1256307572.12174.33.camel@johannes.local> <1256312995.2164.7.camel@localhost.localdomain> <1256313851.12174.131.camel@johannes.local> <1256315335.2164.44.camel@localhost.localdomain> <1256315496.2164.47.camel@localhost.localdomain> <1256315972.12174.168.camel@johannes.local> <1256316179.2164.53.camel@localhost.localdomain> <1256316535.12174.186.camel@johannes.local> Content-Type: text/plain Date: Fri, 23 Oct 2009 09:52:56 -0700 Message-Id: <1256316776.2164.54.camel@localhost.localdomain> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 2009-10-23 at 18:48 +0200, Johannes Berg wrote: > On Fri, 2009-10-23 at 09:42 -0700, Dan Williams wrote: > > > Yeah, I think it's best to handle the mesh WEXT ioctls separately for > > now. There are really only 4 of them (get/set SSID, set channel, get > > mode) that matter for mesh. The rest of the ioctls that the mesh > > interface supports get redirected to the cfg80211 handlers because they > > aren't specific to mesh. > > So why can't we simply do > > set_ssid() > { > if (mesh) > return mesh_set_ssid(); > else > return cfg80211_wext_iwessid() > } The mesh interface is a completely separate netdev, with its own WEXT handler struct. So we'd never be in that situation. Dan