Return-path: Received: from mail-bw0-f227.google.com ([209.85.218.227]:45994 "EHLO mail-bw0-f227.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752348AbZKJPkT (ORCPT ); Tue, 10 Nov 2009 10:40:19 -0500 Received: by bwz27 with SMTP id 27so141909bwz.21 for ; Tue, 10 Nov 2009 07:40:24 -0800 (PST) Message-ID: <4AF98963.7060905@lwfinger.net> Date: Tue, 10 Nov 2009 09:40:19 -0600 From: Larry Finger MIME-Version: 1.0 To: "John W. Linville" CC: Marcel Holtmann , bzolnier@gmail.com, Bernhard Schiffner , linux-wireless@vger.kernel.org Subject: Re: [RFT 6/6] rtl8187se: Modify Kconfig and Makefile References: <4af8a64a.OAu73X3xIXLBXo18%Larry.Finger@lwfinger.net> <1257844855.26914.1.camel@violet> <20091110133407.GA12682@tuxdriver.com> In-Reply-To: <20091110133407.GA12682@tuxdriver.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/10/2009 07:34 AM, John W. Linville wrote: > On Tue, Nov 10, 2009 at 10:20:55AM +0100, Marcel Holtmann wrote: >> Hi Larry, >> >>> Modify configuration and builod system for rtl8187se. >>> >>> Signed-off-by: Larry Finger >>> --- >>> >>> Index: wireless-testing/drivers/net/wireless/Kconfig >>> =================================================================== >>> --- wireless-testing.orig/drivers/net/wireless/Kconfig >>> +++ wireless-testing/drivers/net/wireless/Kconfig >>> @@ -294,6 +294,16 @@ config RTL8187_LEDS >>> depends on RTL8187 && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = RTL8187) >>> default y >>> >>> +config RTL8187SE >>> + tristate "Realtek 8187SE PCI support" >>> + depends on MAC80211 && PCI && WLAN_80211 && EXPERIMENTAL >>> + select EEPROM_93CX6 >>> + ---help--- >>> + This is a driver for RTL8187SE PCI-based cards. If built as a >>> + module, it will be named rtl8187se. >>> + >>> + Thanks to Realtek for their support! >> >> does this really belong into the help text. Having it in the copyright >> header seems enough. Especially since this help text is not offering any >> additional advice or information for the user. > > FWIW, I think Larry basically copied that from the other Realtek > entries. But you are right, it should probably be gone... That is exactly what happened, but it is gone now. Larry