Return-path: Received: from mail-fx0-f213.google.com ([209.85.220.213]:59702 "EHLO mail-fx0-f213.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753884AbZKVPVX (ORCPT ); Sun, 22 Nov 2009 10:21:23 -0500 Date: Sun, 22 Nov 2009 16:21:31 +0100 From: Kristoffer Ericson To: "Rafael J. Wysocki" Cc: Johannes Berg , "John W. Linville" , "Luis R. Rodriguez" , "Justin P. Mattock" , Linux Kernel Mailing List , Kernel Testers List , linux-wireless@vger.kernel.org Subject: Re: [Bug #14267] Disassociating atheros wlan Message-Id: <20091122162131.0e2e60ef.kristoffer.ericson@gmail.com> In-Reply-To: <200911221519.54284.rjw@sisk.pl> References: <7qTjLRFNcGF.A.eSE.kCACLB@chimera> <4B08258E.9050607@gmail.com> <1258886823.7094.101.camel@johannes.local> <200911221519.54284.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, 22 Nov 2009 15:19:54 +0100 "Rafael J. Wysocki" wrote: > On Sunday 22 November 2009, Johannes Berg wrote: > > On Sat, 2009-11-21 at 09:38 -0800, Justin P. Mattock wrote: > > > > > I did a bisect yesterday on this, and the results > > > seemed to have worked over here by reverting: > > > > > > 75e6c3b72b3ab01c47629f3fbd0fed4e6550bf3a > > > cfg80211: lower dynamic PS timeout to 100ms > > > > > > if Kristoffer can try reverting this one > > > to see, then we can go from there. > > > > So that just means the driver is broken. Please run > > > > iwconfig wlan0 power off > > > > to fix it then. And the patch below will disable it by default since > > it's broken. > > > > johannes > > > > --- wireless-testing.orig/drivers/net/wireless/ath/ath9k/main.c 2009-11-22 11:44:41.000000000 +0100 > > +++ wireless-testing/drivers/net/wireless/ath/ath9k/main.c 2009-11-22 11:45:26.000000000 +0100 > > @@ -1893,6 +1893,8 @@ void ath_set_hw_capab(struct ath_softc * > > BIT(NL80211_IFTYPE_ADHOC) | > > BIT(NL80211_IFTYPE_MESH_POINT); > > > > + hw->wiphy->ps_default = false; > > + > > hw->queues = 4; > > hw->max_rates = 4; > > hw->channel_change_time = 5000; > > OK, so perhaps this patch should be applied until th ath9k driver is fixed? Luis? John? I applied the patch from johannes and it ended my issues atleast. I ran my machine for approx 2 hours without seeing the disconnect issue (which I usually saw after 15-25min). Cant be 100% of course but so far so good. I agree with Justin that we could wait until he gets a chance to test it. It should be accepted after initial merge (and stable trees) after that I think. Rafael thoughts? Also, we should notify the atheros people so they could start fixing the driver (in a perfect world). Best wishes Kristoffer Ericson -- Kristoffer Ericson