MIME-Version: 1.0
In-Reply-To: <1258560310.2003.91.camel@violet>
References: <1258557771-10776-1-git-send-email-janakiram.sistla@gmail.com>
	 <1258558500.2003.88.camel@violet>
	 <4fb5db50911180755u4e01814bvcc4d0ec8d396abd@mail.gmail.com>
	 <1258560310.2003.91.camel@violet>
Date: Wed, 18 Nov 2009 22:34:26 +0530
Message-ID: <4fb5db50911180904tf80bef3x37db0f93359d3e7a@mail.gmail.com>
Subject: Re: [PATCH 2/2] Adding kerneldoc entry for radio type GPS
From: Janakiram Sistla <janakiram.sistla@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-wireless-owner@vger.kernel.org

On Wed, Nov 18, 2009 at 9:35 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Janakiram,
>
>> >>
>> >> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> >> index d787d5f..212f555 100644
>> >> --- a/include/linux/rfkill.h
>> >> +++ b/include/linux/rfkill.h
>> >> @@ -36,6 +36,7 @@
>> >> ? * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>> >> ? * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>> >> ? * @RFKILL_TYPE_FM: switch is on a FM device.
>> >> + * @RFKILL_TYPE_GPS: switch is on a GPS device.
>> >> ? * @NUM_RFKILL_TYPES: number of defined rfkill types
>> >> ? */
>> >> ?enum rfkill_type {
>> >
>> > so this is getting stupid right now. I am sick of a really simple patch
>> > causes so much trouble. Even this one is wrong again. The GPS doc should
>> > obviously before FM.
>> Marcel I think you want me to submit GPS doc patch first.I will be
>> doing it shortly and then i will do it for FM.I am sorry for this mis
>> understanding
>
> I don't care in which order you submit the patches, but the order of the
> documentation should match the order in the enum. That is not a strict
> requirement, but here it makes total sense to do so.
>
> Also don't worry with the patches anymore. This took way too much ping
> pong to get it right, that I just wrote them by myself and submitted
> them for inclusion.
>
> Regards
>
> Marcel
>
>
>

I hope in that case  i think it should be give signed off by both for
both the patches.

Regards,
Ram