Return-path: Received: from smtp1.irobot.com ([206.83.81.187]:41275 "EHLO smtp1.irobot.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757896AbZKXToi (ORCPT ); Tue, 24 Nov 2009 14:44:38 -0500 Message-ID: <4B0C37AA.3070805@irobot.com> Date: Tue, 24 Nov 2009 11:44:42 -0800 From: Adam Wozniak MIME-Version: 1.0 To: Johannes Berg CC: Derek Smithies , Christian Lamparter , linux-wireless@vger.kernel.org, Felix Fietkau Subject: Re: [PATCH 2/2] mac80211: minstrel try all rates References: <4AF0D54D.4090303@irobot.com> <4AFDDF19.8060202@irobot.com> <1258191039.6167.40.camel@johannes.local> <4B018B26.2070008@irobot.com> <1258392453.32159.28.camel@johannes.local> <4B0192A6.9050808@irobot.com> <4B01D4A5.7060204@irobot.com> <4B01E298.3030602@irobot.com> <1258443484.1375.8.camel@johannes.local> <4B02DFE3.9040602@irobot.com> <4B0AEEE3.2050808@irobot.com> <1259018866.7094.189.camel@johannes.local> <4B0B2F6E.7050907@irobot.com> <1259025067.7094.208.camel@johannes.local> <4B0C1527.60305@irobot.com> <1259084493.3491.21.camel@johannes.local> <4B0C1E0A.9020003@irobot.com> <1259085518.3491.24.camel@johannes.local> <4B0C2720.3090308@irobot.com> <1259087819.3491.30.camel@johannes.local> <4B0C2938.1050604@irobot.com> <1259089255.3491.31.camel@johannes.local> In-Reply-To: <1259089255.3491.31.camel@johannes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Johannes Berg wrote: > On Tue, 2009-11-24 at 10:43 -0800, Adam Wozniak wrote: > >> As far as I can tell, minstrel_rate_init does not do any allocation. >> The pid_algo version does not appear to do any allocation either. >> > > There are three more -- iwlwifi (2x) and ath9k > Ugh. Why aren't these in with the mac80211 code? Do they rely on something hardware specific? I could not find any allocations in the rate_init in any of these: ./drivers/net/wireless/iwlwifi/iwl-3945-rs.c ./drivers/net/wireless/iwlwifi/iwl-agn-rs.c ./drivers/net/wireless/ath/ath9k/rc.c