Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:34787 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756759AbZKBUpN (ORCPT ); Mon, 2 Nov 2009 15:45:13 -0500 Date: Mon, 2 Nov 2009 15:43:05 -0500 From: "John W. Linville" To: "Luis R. Rodriguez" Cc: Felix Fietkau , Johannes Berg , Sujith , linux-wireless@vger.kernel.org Subject: Re: [PATCH] mac80211: Fix IBSS merge Message-ID: <20091102204304.GL14046@tuxdriver.com> References: <19182.33851.980271.360757@gargle.gargle.HOWL> <1257151486.3555.161.camel@johannes.local> <20091102153614.GC14046@tuxdriver.com> <4AEF14E9.7060902@nbd.name> <43e72e890911020947i3a9ea736ve95fa6b1fac724a4@mail.gmail.com> <4AEF40A0.2030408@openwrt.org> <43e72e890911021236ra2a77baj6436abcc2d86cb3b@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <43e72e890911021236ra2a77baj6436abcc2d86cb3b@mail.gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Nov 02, 2009 at 12:36:31PM -0800, Luis R. Rodriguez wrote: > On Mon, Nov 2, 2009 at 12:27 PM, Felix Fietkau wrote: > > Luis R. Rodriguez wrote: > >> On Mon, Nov 2, 2009 at 9:20 AM, Felix Fietkau wrote: > >>> John W. Linville wrote: > >>>> On Mon, Nov 02, 2009 at 09:44:46AM +0100, Johannes Berg wrote: > >>>>> On Mon, 2009-11-02 at 12:33 +0530, Sujith wrote: > >>>>> > Currently, in IBSS mode, a single creator would go into > >>>>> > a loop trying to merge/scan. This happens because the IBSS timer is > >>>>> > rearmed on finishing a scan and the subsequent > >>>>> > timer invocation requests another scan immediately. > >>>>> > > >>>>> > This patch fixes this issue by checking if we have just completed > >>>>> > a scan run trying to merge with other IBSS networks. > >>>>> > >>>>> Heh, how many people do we need to fix IBSS? :) > >>>> > >>>> Yeah, no kidding...I suspect that actual IBSS users are few, and a > >>>> substantial number of those are doing crazy things with it! :-) > >>> Yeah, we're doing crazy things like mesh networks of few hundred > >>> nodes... something that 11s isn't really suitable for. :-) > >> > >> Anyone know if this applies for 32? > > What exactly? > > The patch. The patch applies and seems sane. It seems like 2.6.32 would need it as well? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.