Return-path: Received: from mail-ew0-f207.google.com ([209.85.219.207]:41550 "EHLO mail-ew0-f207.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411AbZKHOmQ (ORCPT ); Sun, 8 Nov 2009 09:42:16 -0500 Received: by mail-ew0-f207.google.com with SMTP id 3so2399739ewy.37 for ; Sun, 08 Nov 2009 06:42:21 -0800 (PST) Message-ID: <4AF6D8CB.5090302@gmail.com> Date: Sun, 08 Nov 2009 15:42:19 +0100 From: Gertjan van Wingerde MIME-Version: 1.0 To: Ivo van Doorn CC: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org, Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 7/7] rt2x00: Update copyright statements. References: <1257689905-1611-1-git-send-email-gwingerde@gmail.com> <200911081525.58809.IvDoorn@gmail.com> In-Reply-To: <200911081525.58809.IvDoorn@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/08/09 15:25, Ivo van Doorn wrote: > On Sunday 08 November 2009, Gertjan van Wingerde wrote: >> As mentioned on the linux-wireless mailing list, the current copyright statements in the rt2x00 are >> meaningless, as the rt2x00 project is not even a formal legal entity. Therefore it is better to replace >> the existing copyright statements with copyright statements for the people that actually wrote the code. >> >> Note: Updated to the best of my knowledge with respect to who contributed considerable amounts of code. > > ... > >> diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig >> index b0f4a2f..5322852 100644 >> --- a/drivers/net/wireless/rt2x00/Kconfig >> +++ b/drivers/net/wireless/rt2x00/Kconfig >> @@ -65,7 +65,7 @@ config RT2800PCI_SOC >> >> config RT2800PCI >> tristate "Ralink rt2800 (PCI/PCMCIA) support (BROKEN)" >> - depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL && BROKEN >> + depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL >> select RT2800_LIB >> select RT2X00_LIB_PCI if RT2800PCI_PCI >> select RT2X00_LIB_SOC if RT2800PCI_SOC > > You can omit this part of your patch. ;) Ouch. I really messed this one up :-( > >> This program is free software; you can redistribute it and/or modify >> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c >> index 5c7d74a..3207b83 100644 >> --- a/drivers/net/wireless/rt2x00/rt2800lib.c >> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c >> @@ -3,7 +3,13 @@ >> >> Based on the original rt2800pci.c and rt2800usb.c: >> >> - Copyright (C) 2004 - 2009 rt2x00 SourceForge Project >> + Copyright (C) 2009 Ivo van Doorn >> + Copyright (C) 2009 Alban Browaeys >> + Copyright (C) 2009 Felix Fietkau >> + Copyright (C) 2009 Luis Correia >> + Copyright (C) 2009 Mattias Nissler >> + Copyright (C) 2009 Mark Asselstine >> + Copyright (C) 2009 Xose Vazquez Perez >> >> >> This program is free software; you can redistribute it and/or modify > > If Bartlomiej has no objections, we could just update the statements for rt2800lib.c/rt2800lib.h > to something similar as rt2800.h: > > /* > Copyright (C) 2009 Bartlomiej Zolnierkiewicz > Copyright (C) 2009 Ivo van Doorn > Copyright (C) 2009 Alban Browaeys > Copyright (C) 2009 Felix Fietkau > Copyright (C) 2009 Luis Correia > Copyright (C) 2009 Mattias Nissler > Copyright (C) 2009 Mark Asselstine > Copyright (C) 2009 Xose Vazquez Perez > > This program is free software; you can redistribute it and/or modify > .... > > because not sure if we need the seperate "based on" comment.. But I'll let Bartlomiej > decide on this one. > > For the the remaining part: > > Acked-by: Ivo van Doorn > OK. I'll do the change in rt2800lib as well and resubmit. --- Gertjan.