Return-path: Received: from mail-bw0-f227.google.com ([209.85.218.227]:61661 "EHLO mail-bw0-f227.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752318AbZK3RZT (ORCPT ); Mon, 30 Nov 2009 12:25:19 -0500 Received: by bwz27 with SMTP id 27so2722318bwz.21 for ; Mon, 30 Nov 2009 09:25:24 -0800 (PST) Message-ID: <4B13FFFF.4050801@lwfinger.net> Date: Mon, 30 Nov 2009 11:25:19 -0600 From: Larry Finger MIME-Version: 1.0 To: =?UTF-8?B?0KLRhdCw0Lkg0JrQuNGA0LjQu9C7?= CC: Herton Ronaldo Krzesinski , Hin-Tak Leung , linux-wireless@vger.kernel.org Subject: Re: [PATCH]rtl8187:fixed kernel panic on module unload References: <63741259601663@webmail119.yandex.ru> In-Reply-To: <63741259601663@webmail119.yandex.ru> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/30/2009 11:21 AM, Тхай Кирилл wrote: > From: Tkhai Kirill > > rtl8187: fix kernel panic on module unload (BUG in rtl8187_leds_exit()) > Signed-off-by: Tkhai Kirill > --- > The function rtl8187_leds_exit must not return until all LED's works > in device workqueue have completed or cancelled. Otherwise, we can get > the folowing: > wq = create_singlethread_workqueue("phyX"); > > INIT_DELAYED_WORK(&work, work_func); > queue_delayed_work(wq, &work, HZ/20); > > destroy_workqueue(wq); > > =======>kernel panic > On current vanila driver code (when running on SMP systems), panic happens > almost every time. My patch for version 2.6.31 (and 2.6.31.6 too): > > --- a/drivers/net/wireless/rtl818x/rtl8187_leds.c.orig 2009-11-26 22:26:45.000000000 +0300 > +++ b/drivers/net/wireless/rtl818x/rtl8187_leds.c 2009-11-28 18:22:26.659785533 +0300 > @@ -36,9 +36,6 @@ static void led_turn_on(struct work_stru > if (priv->mode == NL80211_IFTYPE_UNSPECIFIED) > return ; > > - /* Skip if the LED is not registered. */ > - if (!led->dev) > - return; > mutex_lock(&priv->conf_mutex); > switch (led->ledpin) { > case LED_PIN_GPIO0: > @@ -74,9 +71,6 @@ static void led_turn_off(struct work_str > if (priv->mode == NL80211_IFTYPE_UNSPECIFIED) > return ; > > - /* Skip if the LED is not registered. */ > - if (!led->dev) > - return; > mutex_lock(&priv->conf_mutex); > switch (led->ledpin) { > case LED_PIN_GPIO0: > @@ -208,12 +202,12 @@ void rtl8187_leds_exit(struct ieee80211_ > { > struct rtl8187_priv *priv = dev->priv; > > - /* turn the LED off before exiting */ > - queue_delayed_work(dev->workqueue, &priv->led_off, 0); > - cancel_delayed_work_sync(&priv->led_off); > - cancel_delayed_work_sync(&priv->led_on); > rtl8187_unregister_led(&priv->led_rx); > rtl8187_unregister_led(&priv->led_tx); > + cancel_delayed_work_sync(&priv->led_on); > + /* turn the LED off before exiting */ > + queue_delayed_work(dev->workqueue, &priv->led_off, 0); > + flush_workqueue(dev->workqueue); > } > #endif /* def CONFIG_RTL8187_LED */ Have you applied the fix in mainline commit 37b12dd2b07b4d7dc222a5f7f88b25cec532b2aa? It should have fixed this problem. Larry