Return-path: Received: from mail-bw0-f227.google.com ([209.85.218.227]:36078 "EHLO mail-bw0-f227.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754806AbZKIWq5 convert rfc822-to-8bit (ORCPT ); Mon, 9 Nov 2009 17:46:57 -0500 Received: by bwz27 with SMTP id 27so4022805bwz.21 for ; Mon, 09 Nov 2009 14:47:02 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1257805265.21134.22738.camel@rc-desk> References: <1257787187.21134.22331.camel@rc-desk> <1257805265.21134.22738.camel@rc-desk> Date: Mon, 9 Nov 2009 17:47:02 -0500 Message-ID: Subject: Re: [PATCH] iwlcore: Allow runtime configuration of no_sleep_autoadjust From: Andrew Lutomirski To: reinette chatre Cc: "ilw@linux.intel.com" , "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Nov 9, 2009 at 5:21 PM, reinette chatre wrote: > Hi Andrew, > > On Mon, 2009-11-09 at 10:07 -0800, Andrew Lutomirski wrote: >> Hmm. ?It looks like sleep_level_override in debugfs can do exactly what I want. > > You have not really stated what you are trying to do here so it is hard > to tell. sleep_level_override lets you hardcode the power saving index. > >> >> Is there any reason that no_sleep_autoadjust doesn't just make >> sleep_level_override default to 1? > > That does seem what it is doing in iwl_power_update_mode(). I want to save power. no_sleep_autoadjust=N and iwconfig wlan0 power on does a good job of that. I assume that no_sleep_autoadjust defaults to Y because it's still not reliable (and I seem to have seen a few networks where it causes occasional problems). So I'd like to be able to toggle it at runtime, file bug reports when it fails, but still be able to use the networks it fails on :) --Andy