Return-path: Received: from mail-ew0-f219.google.com ([209.85.219.219]:50766 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbZLATRI (ORCPT ); Tue, 1 Dec 2009 14:17:08 -0500 Received: by ewy19 with SMTP id 19so5286899ewy.21 for ; Tue, 01 Dec 2009 11:17:14 -0800 (PST) From: Ivo van Doorn To: Benoit Papillault Subject: Re: [PATCH 1/2] rt2x00: Disable RX aggregation for rt2800usb Date: Tue, 1 Dec 2009 20:17:11 +0100 Cc: gwingerde@gmail.com, linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com, Luis Correia References: <1259619690-2749-1-git-send-email-benoit.papillault@free.fr> In-Reply-To: <1259619690-2749-1-git-send-email-benoit.papillault@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Message-Id: <200912012017.11986.IvDoorn@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Monday 30 November 2009, Benoit Papillault wrote: > From: Benoit PAPILLAULT > > RX aggregation is a way to receive multiple 802.11 frames in one RX buffer. > However, we don't know yet how to handle this case in rt2800usb_fill_rxdone > and this has probably no impact on RX performance as well, so we disable it > > Signed-off-by: Benoit Papillault > --- > drivers/net/wireless/rt2x00/rt2800usb.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c > index af85d18..ed31763 100644 > --- a/drivers/net/wireless/rt2x00/rt2800usb.c > +++ b/drivers/net/wireless/rt2x00/rt2800usb.c > @@ -295,9 +295,7 @@ static int rt2800usb_enable_radio(struct rt2x00_dev *rt2x00dev) > > rt2800_register_read(rt2x00dev, USB_DMA_CFG, ®); > rt2x00_set_field32(®, USB_DMA_CFG_PHY_CLEAR, 0); > - /* Don't use bulk in aggregation when working with USB 1.1 */ > - rt2x00_set_field32(®, USB_DMA_CFG_RX_BULK_AGG_EN, > - (rt2x00dev->rx->usb_maxpacket == 512)); > + rt2x00_set_field32(®, USB_DMA_CFG_RX_BULK_AGG_EN, 0); > rt2x00_set_field32(®, USB_DMA_CFG_RX_BULK_AGG_TIMEOUT, 128); > /* > * Total room for RX frames in kilobytes, PBF might still exceed Are you sure this works? I think Luis tried this 2 weeks ago and it didn't disable the aggregation... (Luis, please confirm that this was indeed the change you made...) Ivo