Return-path: Received: from smtp.nokia.com ([192.100.105.134]:22278 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750855AbZLKNQb (ORCPT ); Fri, 11 Dec 2009 08:16:31 -0500 Message-ID: <4B22460A.9060804@nokia.com> Date: Fri, 11 Dec 2009 15:15:54 +0200 From: Luciano Coelho MIME-Version: 1.0 To: "Oikarinen Juuso (Nokia-D/Tampere)" CC: ext Johannes Berg , "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH 21/31] wl1271: prevent power save entry while not associated References: <1260531682-4695-1-git-send-email-luciano.coelho@nokia.com> <1260531682-4695-22-git-send-email-luciano.coelho@nokia.com> <1260532418.2442.129.camel@johannes.local> <1260533355.2689.45.camel@wimaxnb.ntc.nokia.com> In-Reply-To: <1260533355.2689.45.camel@wimaxnb.ntc.nokia.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Oikarinen Juuso (Nokia-D/Tampere) wrote: > Hi, > > Unfortunately I haven't had the time to investigate this further, but > for me it did happen after getting de-authenticated from an AP and > attempting to re-authenticate. While re-authenticating, mac80211 > appeared to request going into power save after transmitting the > corresponding control messages, preventing the re-authentication from > succeeding. > > My assumption is, that the dynamic power save mechanism is somehow > getting triggered from the control message exchange - but, as I said, I > cannot be sure at this point. > > -Juuso > > On Fri, 2009-12-11 at 12:53 +0100, ext Johannes Berg wrote: >> On Fri, 2009-12-11 at 13:41 +0200, Luciano Coelho wrote: >>> From: Juuso Oikarinen >>> >>> The mac80211 sometimes requests power save entry while not associated - this >>> will cause problems, so prevent it if not associated. Go to powersave once >>> association is complete. >> Does it? It's not supposed to, and I imagine that causing trouble with >> other drivers too. Do you know how that happens? I'll keep this patch for now. Later, if the issue with mac80211 is found and fixed, we can remove the code if needed. -- Cheers, Luca.