Return-path: Received: from ey-out-2122.google.com ([74.125.78.24]:28899 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753398AbZLAT7i convert rfc822-to-8bit (ORCPT ); Tue, 1 Dec 2009 14:59:38 -0500 Received: by ey-out-2122.google.com with SMTP id 4so1283340eyf.19 for ; Tue, 01 Dec 2009 11:59:44 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <200912012017.11986.IvDoorn@gmail.com> References: <1259619690-2749-1-git-send-email-benoit.papillault@free.fr> <200912012017.11986.IvDoorn@gmail.com> Date: Tue, 1 Dec 2009 19:59:43 +0000 Message-ID: <880c1630912011159m604ee187xa496c00a800f1100@mail.gmail.com> Subject: Re: [rt2x00-users] [PATCH 1/2] rt2x00: Disable RX aggregation for rt2800usb From: Luis Correia To: rt2x00 Users List Cc: Benoit Papillault , Luis Correia , linux-wireless@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Dec 1, 2009 at 19:17, Ivo van Doorn wrote: > On Monday 30 November 2009, Benoit Papillault wrote: >> From: Benoit PAPILLAULT >> >> RX aggregation is a way to receive multiple 802.11 frames in one RX buffer. >> However, we don't know yet how to handle this case in rt2800usb_fill_rxdone >> and this has probably no impact on RX performance as well, so we disable it >> >> Signed-off-by: Benoit Papillault >> --- >> ?drivers/net/wireless/rt2x00/rt2800usb.c | ? ?4 +--- >> ?1 files changed, 1 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c >> index af85d18..ed31763 100644 >> --- a/drivers/net/wireless/rt2x00/rt2800usb.c >> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c >> @@ -295,9 +295,7 @@ static int rt2800usb_enable_radio(struct rt2x00_dev *rt2x00dev) >> >> ? ? ? rt2800_register_read(rt2x00dev, USB_DMA_CFG, ®); >> ? ? ? rt2x00_set_field32(®, USB_DMA_CFG_PHY_CLEAR, 0); >> - ? ? /* Don't use bulk in aggregation when working with USB 1.1 */ >> - ? ? rt2x00_set_field32(®, USB_DMA_CFG_RX_BULK_AGG_EN, >> - ? ? ? ? ? ? ? ? ? ? ? ?(rt2x00dev->rx->usb_maxpacket == 512)); >> + ? ? rt2x00_set_field32(®, USB_DMA_CFG_RX_BULK_AGG_EN, 0); >> ? ? ? rt2x00_set_field32(®, USB_DMA_CFG_RX_BULK_AGG_TIMEOUT, 128); >> ? ? ? /* >> ? ? ? ?* Total room for RX frames in kilobytes, PBF might still exceed > > > Are you sure this works? I think Luis tried this 2 weeks ago and it didn't > disable the aggregation... (Luis, please confirm that this was indeed the change you made...) Yes, it was one of the changes I made. However, I wouldn't say that it didn't disable aggregation, it just didn't fix the problem I was pursuing (receiving 11n beacon frames). So I guess that for now, we could just go with it disabled and try later on to enable it when the driver is more useable. Luis Correia