Return-path: Received: from adsl-67-113-118-6.dsl.sndg02.pacbell.net ([67.113.118.6]:54820 "EHLO multivac.one-eyed-alien.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716AbZLPTxc (ORCPT ); Wed, 16 Dec 2009 14:53:32 -0500 Date: Wed, 16 Dec 2009 11:52:58 -0800 From: Matthew Dharm To: Dan Williams Cc: Oliver Neukum , Josua Dietze , Stefan Seyfried , linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, Stefan Seyfried Subject: Re: [PATCH] move eject code from zd1211rw to usb-storage Message-ID: <20091216195258.GJ16426@one-eyed-alien.net> References: <1260878800-14691-1-git-send-email-stefan.seyfried@googlemail.com> <200912151611.08576.oliver@neukum.org> <20091215180300.GF16426@one-eyed-alien.net> <200912161129.27284.oliver@neukum.org> <20091216180337.GG16426@one-eyed-alien.net> <1260993048.2179.68.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="aF3LVLvitz/VQU3c" In-Reply-To: <1260993048.2179.68.camel@localhost.localdomain> Sender: linux-wireless-owner@vger.kernel.org List-ID: --aF3LVLvitz/VQU3c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 16, 2009 at 11:50:48AM -0800, Dan Williams wrote: > On Wed, 2009-12-16 at 10:03 -0800, Matthew Dharm wrote: > > On Wed, Dec 16, 2009 at 11:29:27AM +0100, Oliver Neukum wrote: > > > Am Dienstag, 15. Dezember 2009 19:03:00 schrieb Matthew Dharm: > > > > > This would break existing systems and thus introduce a regression. > > > > > We'd need to go through a feature removal process. For the time b= eing > > > > > I see no alternative to Seife's patch, as we cannot introduce eje= ction > > > > > code to another wireless driver and need to support these devices. > > > >=20 > > > > The right answer here is neither to move the eject code nor to intr= oduce > > > > more of it. New devices should be supported via userspace. > > >=20 > > > Usually I would agree, but in this case the vendor reused IDs. > > > The legacy kernel space switcher and user space would race. > >=20 > > So, let me see if I understand this... we have two devices that use the > > same IDs, and get mode-switched the same way, but need different > > post-switch drivers? > >=20 > > If this is the case, then the only reasonable answer to is to push the > > modeswitch code for both into udev and out of the kernel. It will take >=20 > you mean usb_modeswitch, not udev actually. That is correct; I had mis-typed. Tho, the actual implementation is udev calling usb_modeswitch and/or eject. Matt --=20 Matthew Dharm Home: mdharm-usb@one-eyed-alien.= net=20 Maintainer, Linux USB Mass Storage Driver What, are you one of those Microsoft-bashing Linux freaks? -- Customer to Greg User Friendly, 2/10/1999 --aF3LVLvitz/VQU3c Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFLKTqaHL9iwnUZqnkRAln8AJ0f+DvWRNY2JgW12rky9Xuq7ZwKrACfUcv+ S89OrVvmBdfIVmZLZKNIRcQ= =H4ig -----END PGP SIGNATURE----- --aF3LVLvitz/VQU3c--