Return-path: Received: from mail-fx0-f221.google.com ([209.85.220.221]:58111 "EHLO mail-fx0-f221.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751296AbZLPNGO (ORCPT ); Wed, 16 Dec 2009 08:06:14 -0500 Message-ID: <4B28DBB6.5030304@gmail.com> Date: Wed, 16 Dec 2009 14:08:06 +0100 From: Roel Kluin MIME-Version: 1.0 To: Samuel Ortiz , Zhu Yi , Intel Linux Wireless , linux-wireless@vger.kernel.org, Andrew Morton , LKML Subject: [PATCH] iwmc3200wifi: Fix test of unsigned in iwm_ntf_stop_resume_tx() Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: `queue' is unsigned so the test did not work. Signed-off-by: Roel Kluin --- Found using coccinelle: http://coccinelle.lip6.fr/ diff --git a/drivers/net/wireless/iwmc3200wifi/rx.c b/drivers/net/wireless/iwmc3200wifi/rx.c index 1c57c1f..9ac72e4 100644 --- a/drivers/net/wireless/iwmc3200wifi/rx.c +++ b/drivers/net/wireless/iwmc3200wifi/rx.c @@ -1128,7 +1128,7 @@ static int iwm_ntf_stop_resume_tx(struct iwm_priv *iwm, u8 *buf, struct iwm_tx_queue *txq; u16 queue = iwm_tid_to_queue(bit); - if (queue < 0) + if (queue == -EINVAL) continue; txq = &iwm->txq[queue];