Return-path: Received: from mail-pw0-f42.google.com ([209.85.160.42]:61122 "EHLO mail-pw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750845Ab0AYSZ3 convert rfc822-to-8bit (ORCPT ); Mon, 25 Jan 2010 13:25:29 -0500 Received: by pwi21 with SMTP id 21so2425108pwi.21 for ; Mon, 25 Jan 2010 10:25:29 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20100123105111.GA24790@progeny.tock> <20100123134005.GA11322@progeny.tock> From: "Luis R. Rodriguez" Date: Mon, 25 Jan 2010 10:25:09 -0800 Message-ID: <43e72e891001251025s1e3fa358v31527d1b5f7e3436@mail.gmail.com> Subject: Re: ath5k phy0: unsupported jumbo To: Bob Copeland Cc: Jonathan Nieder , Kacper , linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, Jan 23, 2010 at 10:32 AM, Bob Copeland wrote: > On Sat, Jan 23, 2010 at 8:40 AM, Jonathan Nieder wrote: >> So it looks like we receive some strange packets that haven’t been >> explained yet.  It might be worth looking at a few --- sounds kind of >> interesting. >> >> Am I understanding correctly?  This is a hardware bug or undocumented >> hardware feature then, right? >> >> It might be nice to add some user-oriented explanation too, but for >> now, how about this comment? >> > > That's ok with me.  I'd also be fine with removing the log spam.  I think > ultimately it represents some kind of driver issue, I'm just not sure what, > exactly, yet.  I recently added more debugging to a kernel on a system of > mine that produces it more often -- I'll see what it turns up. Jumbo frames are frames which the hardware receives for which it does not have enough DMA leg room for, and so needs to split it out into multiple descriptors. It should be OK to just drop them if ath5k is setting the max RX dma size to the max 802.11 frame, as they could be bogus frames or 11n AMSDU frames which ath5k obviously would not support. Luis