Return-path: Received: from mail-pz0-f172.google.com ([209.85.222.172]:40196 "EHLO mail-pz0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751457Ab0AUS4h convert rfc822-to-8bit (ORCPT ); Thu, 21 Jan 2010 13:56:37 -0500 Received: by pzk2 with SMTP id 2so219037pzk.21 for ; Thu, 21 Jan 2010 10:56:37 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1264099093.11396.62.camel@johannes.local> References: <20100121025546.GB8069@bombadil.infradead.org> <1264067069.11396.33.camel@johannes.local> <43e72e891001211016i617de5c6o24fdfd1aa6f54eeb@mail.gmail.com> <1264099093.11396.62.camel@johannes.local> From: "Luis R. Rodriguez" Date: Thu, 21 Jan 2010 10:56:17 -0800 Message-ID: <43e72e891001211056g104b8eb4u26e1d21b449a26db@mail.gmail.com> Subject: Re: RFC/RFT: compat-wireless for 2.6.32.4 - MQ backport support To: Johannes Berg Cc: "Luis R. Rodriguez" , linux-wireless Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Jan 21, 2010 at 10:38 AM, Johannes Berg wrote: > On Thu, 2010-01-21 at 10:16 -0800, Luis R. Rodriguez wrote: >> On Thu, Jan 21, 2010 at 1:44 AM, Johannes Berg >> wrote: >> > On Wed, 2010-01-20 at 21:55 -0500, Luis R. Rodriguez wrote: >> > >> >> @@ -287,7 +287,13 @@ >> >> >> >>       rcu_read_lock(); >> >>       list_for_each_entry_rcu(sdata, &local->interfaces, list) >> >> +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,27)) >> >>               netif_tx_wake_queue(netdev_get_tx_queue(sdata->dev, queue)); >> >> +#elif (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23)) >> >> +             netif_start_subqueue(sdata->dev, queue); >> >> +#else >> >> +             netif_wake_queue(sdata->dev); >> >> +#endif >> > >> > That's incorrect, you need to check for all hardware queues being awake. >> >> Can you elaborate? I'm not following. > > Well something like > > stopped = 0; > for (i = 0; i < hw_queues; i++) >        if (queue_stop_reason[i]) >                stopped++; > > if (stopped == 0) >        netif_wake_queue() Got it, thanks. Luis