Return-path: Received: from mail-yx0-f188.google.com ([209.85.210.188]:60555 "EHLO mail-yx0-f188.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932676Ab0AFVXh (ORCPT ); Wed, 6 Jan 2010 16:23:37 -0500 Received: by yxe26 with SMTP id 26so17060884yxe.4 for ; Wed, 06 Jan 2010 13:23:37 -0800 (PST) Message-ID: <4B44FF56.6080204@lwfinger.net> Date: Wed, 06 Jan 2010 15:23:34 -0600 From: Larry Finger MIME-Version: 1.0 To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= CC: "linux-wireless@vger.kernel.org" , "John W. Linville" , "bcm43xx-dev@lists.berlios.de" Subject: Re: [PATCH 2/5] b43: N-PHY: add b43_nphy_get_tx_gains (V2) References: <43e72e891001060926s320bf403ya2edf2601ced5125@mail.gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 01/06/2010 02:57 PM, Rafał Miłecki wrote: > V2: adjust to renamed function, fill index array > > Signed-off-by: Rafał Miłecki > --- > drivers/net/wireless/b43/phy_n.c | 81 Just a little nitpick to save John some work, and to keep the patches straight. When you submit a second (or later) version of a patch, indicate the version in the mail header as in [PATCH 2/5 V2] b43:.... The upstream software strips all of that out and the commit header will be clean. In addition, it is useful to state what is different below the --- marker. The software also strips that part of the patch - the permanent commit message should be devoid of the details of the review message. It is like making sausage! Better that the details are hidden. Larry