Return-path: Received: from mail-ew0-f219.google.com ([209.85.219.219]:56782 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754462Ab0AYSg3 convert rfc822-to-8bit (ORCPT ); Mon, 25 Jan 2010 13:36:29 -0500 Received: by ewy19 with SMTP id 19so50019ewy.21 for ; Mon, 25 Jan 2010 10:36:28 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1264442401-6364-1-git-send-email-zajec5@gmail.com> <1264442401-6364-3-git-send-email-zajec5@gmail.com> <201001251932.14633.mb@bu3sch.de> Date: Mon, 25 Jan 2010 19:36:27 +0100 Message-ID: Subject: Re: [PATCH 2/4] b43: make cordic common (LP-PHY and N-PHY need it) From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Michael Buesch Cc: bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org, "John W. Linville" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: W dniu 25 stycznia 2010 19:35 użytkownik Rafał Miłecki napisał: > 2010/1/25 Michael Buesch : >> On Monday 25 January 2010 18:59:59 Rafał Miłecki wrote: >>> +/* Complex number using 2 32-bit signed integers */ >>> +typedef struct { s32 i, q; } b43_c32; >> >> No typedef. ever. > > Well, I just copied (Gabor's?) code here. But of course I can fix this > by the way, no problem :) > > Just read about typedef in Linux Kernel Coding Style, didn't know > about this earlier. Thanks for pointing. Is this OK to fix this in separated patch? Or should I modify this set of patches? -- Rafał