Return-path: Received: from mail-yx0-f187.google.com ([209.85.210.187]:39312 "EHLO mail-yx0-f187.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088Ab0AWTB7 (ORCPT ); Sat, 23 Jan 2010 14:01:59 -0500 Received: by yxe17 with SMTP id 17so1853384yxe.33 for ; Sat, 23 Jan 2010 11:01:59 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20100123182714.15374.3093.stgit@tikku> References: <20100123182714.15374.3093.stgit@tikku> Date: Sat, 23 Jan 2010 14:01:58 -0500 Message-ID: Subject: Re: [PATCH] mac80211: fix tx select key null pointer crash with hostapd From: Bob Copeland To: Kalle Valo Cc: linux-wireless@vger.kernel.org, Pavel Roskin , Johannes Berg Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, Jan 23, 2010 at 1:27 PM, Kalle Valo wrote: > Pavel Roskin reported a crash in ieee80211_tx_h_select_key(): > > http://marc.info/?l=linux-wireless&m=126419655108528&w=2 > > This is a regression from patch "mac80211: move control.hw_key assignment". > Fix it as suggested by Johannes, adding an else statement to make sure > that tx->key is not accessed when it's null. > > Compile-tested only. > > Reported-by: Pavel Roskin > Cc: Johannes Berg > Signed-off-by: Kalle Valo Tested-by: Bob Copeland Thanks! -- Bob Copeland %% www.bobcopeland.com