Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:45575 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753659Ab0AYWai (ORCPT ); Mon, 25 Jan 2010 17:30:38 -0500 Date: Mon, 25 Jan 2010 17:19:35 -0500 From: "John W. Linville" To: Michael Buesch Cc: bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org Subject: Re: [PATCH 2/4] b43: make cordic common (LP-PHY and N-PHY need it) Message-ID: <20100125221935.GC14699@tuxdriver.com> References: <1264442401-6364-1-git-send-email-zajec5@gmail.com> <201001251953.21692.mb@bu3sch.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <201001251953.21692.mb@bu3sch.de> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jan 25, 2010 at 07:53:19PM +0100, Michael Buesch wrote: > On Monday 25 January 2010 19:36:27 Rafał Miłecki wrote: > > W dniu 25 stycznia 2010 19:35 użytkownik Rafał Miłecki > > napisał: > > > 2010/1/25 Michael Buesch : > > >> On Monday 25 January 2010 18:59:59 Rafał Miłecki wrote: > > >>> +/* Complex number using 2 32-bit signed integers */ > > >>> +typedef struct { s32 i, q; } b43_c32; > > >> > > >> No typedef. ever. > > > > > > Well, I just copied (Gabor's?) code here. But of course I can fix this > > > by the way, no problem :) > > Yeah, I saw that. We can fix it while we're at it. ;) > > > > Just read about typedef in Linux Kernel Coding Style, didn't know > > > about this earlier. Thanks for pointing. > > > > Is this OK to fix this in separated patch? Or should I modify this set > > of patches? > > Well, as you touch any reference to the typedef anyway (you renamed it), > you can just put the keyword "struct" in front of the references and no separate patch is needed. > It won't even grow your current patch in the number of changed lines. I took care of these modifications to the original patch... John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.