Return-path: Received: from li59-9.members.linode.com ([97.107.129.9]:57207 "EHLO erley.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753482Ab0AVPM3 (ORCPT ); Fri, 22 Jan 2010 10:12:29 -0500 MIME-Version: 1.0 Date: Fri, 22 Jan 2010 10:12:27 -0500 From: To: Johannes Berg Cc: "Luis R. Rodriguez" , linux-wireless , Subject: Re: [RFC/RFT v2]: compat-wireless for 2.6.32.4 - multiqueue backport support In-Reply-To: <1264170474.11396.86.camel@johannes.local> References: <20100121230600.GC8069@bombadil.infradead.org> <1264152878.11396.82.camel@johannes.local> <76acc753e1ea73bdffe1a9772f58bba2@127.0.0.1> <1264170474.11396.86.camel@johannes.local> Message-ID: <27754891007713351b268f757b1aae7c@127.0.0.1> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 22 Jan 2010 15:27:54 +0100, Johannes Berg wrote: > On Fri, 2010-01-22 at 09:14 -0500, pat-lkml@erley.org wrote: >> On Fri, 22 Jan 2010 10:34:38 +0100, Johannes Berg >> wrote: >> > On Thu, 2010-01-21 at 18:06 -0500, Luis R. Rodriguez wrote: >> > >> >> +#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,23)) >> >> +static bool ieee80211_all_queues_stopped(struct ieee80211_hw *hw) >> > >> > You want "all queues started" :) >> > >> Are you certain of this? I stared and stared trying to see what case >> the function would behave as a "started" check. It loops through all >> queues, returning false if it finds any started queues. If it makes >> it through all the queues and hasn't found a single started queue, it >> returns true (to indicate all queues are stopped). >> >> Or do you mean, as a second function? > > No, I mean instead. The function is named correctly for what it does, > but it does the wrong thing for the logic where it is used. Ahh, didn't scroll down to look at usage context. That does make sense. Pat