Subject: Re: [PATCH] ath9k_htc: Add ath9k_htc driver
From: Pavel Roskin <proski@gnu.org>
To: Sujith <Sujith.Manoharan@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	Vasanth.Thiagarajan@Atheros.com,
	Senthilkumar.Balasubramanian@Atheros.com
In-Reply-To: <19335.43241.887933.207404@gargle.gargle.HOWL>
References: <19335.43241.887933.207404@gargle.gargle.HOWL>
Content-Type: text/plain
Date: Fri, 26 Feb 2010 13:33:21 -0500
Message-Id: <1267209201.30426.8.camel@mj>
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Fri, 2010-02-26 at 16:26 +0530, Sujith wrote:

> Support for AR9271 chipset.

Great news!!!

> --- a/drivers/net/wireless/ath/ath9k/calib.h
> +++ b/drivers/net/wireless/ath/ath9k/calib.h
> @@ -114,6 +114,7 @@ struct ath9k_nfcal_hist {
>  };
>  
>  #define MAX_PACAL_SKIPCOUNT 8
> +
>  struct ath9k_pacal_info{

You may want to omit this part ;-)

> @@ -1240,7 +1228,7 @@ void ath9k_hw_deinit(struct ath_hw *ah)
>  {
>  	struct ath_common *common = ath9k_hw_common(ah);
>  
> -	if (common->state <= ATH_HW_INITIALIZED)
> +	if (common->state < ATH_HW_INITIALIZED)
>  		goto free_hw;
>  
>  	if (!AR_SREV_9100(ah))

There are some non-trivial parts like this one that could be submitted
separately.

> @@ -1249,10 +1237,8 @@ void ath9k_hw_deinit(struct ath_hw *ah)
>  	ath9k_hw_setpower(ah, ATH9K_PM_FULL_SLEEP);
>  
>  free_hw:
> -	if (!AR_SREV_9280_10_OR_LATER(ah))
> +	if (!AR_SREV_9280_10_OR_LATER(ah) && !AR_SREV_9271(ah))
>  		ath9k_hw_rf_free_ext_banks(ah);
> -	kfree(ah);
> -	ah = NULL;

Another one.  Actually, it is trivial, but not ath9k_htc related.

It would be really nice to fast track the ath9k_htc driver to 2.6.34,
but the changes affecting other devices should be separate, I believe.

-- 
Regards,
Pavel Roskin