Return-path: Received: from out1.smtp.messagingengine.com ([66.111.4.25]:43184 "EHLO out1.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934514Ab0BYXpw (ORCPT ); Thu, 25 Feb 2010 18:45:52 -0500 Date: Thu, 25 Feb 2010 20:35:16 -0300 From: Henrique de Moraes Holschuh To: florian@mickler.org Cc: Marcel Holtmann , Johannes Berg , "John W. Linville" , linux-wireless@vger.kernel.org, Randy Dunlap , Alan Jenkins , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH v2 2/2] enhance sysfs rfkill interface Message-ID: <20100225233516.GD5218@khazad-dum.debian.net> References: <1266704345.32739.0.camel@jlt3.sipsolutions.net> <1267009517-5017-3-git-send-email-florian@mickler.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1267009517-5017-3-git-send-email-florian@mickler.org> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 24 Feb 2010, florian@mickler.org wrote: > /sys/class/rfkill/rfkill[0-9]+/hw: (ro) > hardblock kill state > /sys/class/rfkill/rfkill[0-9]+/sw: (rw) > softblock kill state > > Signed-off-by: Florian Mickler > --- > > I am not shure about those names. I don't like them. IMHO, you don't gain anything by being this terse, and it is difficult to understand what they mean at first glance. > Other alternatives: > [hs]w_block > block_[hs]w Any of those would be good, IMHO. As would be more verbose variants like: hardware_blocked, software_blocked, etc. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh