Return-path: Received: from senator.holtmann.net ([87.106.208.187]:56057 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933276Ab0BPXGj (ORCPT ); Tue, 16 Feb 2010 18:06:39 -0500 Subject: Re: [PATCH 1/2] input: Add KEY_RFKILL From: Marcel Holtmann To: Matthew Garrett Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com In-Reply-To: <1266356185-10324-1-git-send-email-mjg@redhat.com> References: <1266356185-10324-1-git-send-email-mjg@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 16 Feb 2010 15:05:19 -0800 Message-ID: <1266361519.8849.28.camel@localhost.localdomain> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Matthew, > Most laptops have keys that are intended to toggle all device state, not > just wifi. These are currently generally mapped to KEY_WLAN. As a result, > rfkill will only kill or enable wifi in response to the key press. This > confuses users and can make it difficult for them to enable bluetooth > and wwan devices. > > This patch adds a new keycode, KEY_RFKILL. It indicates that the system > should toggle the state of all rfkillable devices. > > Signed-off-by: Matthew Garrett Acked-by: Marcel Holtmann Regards Marcel