Return-path: Received: from mail-ew0-f220.google.com ([209.85.219.220]:37022 "EHLO mail-ew0-f220.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936344Ab0B1BhW convert rfc822-to-8bit (ORCPT ); Sat, 27 Feb 2010 20:37:22 -0500 Received: by ewy20 with SMTP id 20so695953ewy.21 for ; Sat, 27 Feb 2010 17:37:21 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <201002271551.26126.mb@bu3sch.de> References: <1265745883-3392-2-git-send-email-zajec5@gmail.com> <201002100002.11369.mb@bu3sch.de> <201002271551.26126.mb@bu3sch.de> Date: Sun, 28 Feb 2010 02:37:21 +0100 Message-ID: Subject: Re: [PATCH 01/11] b43: N-PHY: add some registers and structs definitions From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Michael Buesch Cc: bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org, "John W. Linville" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: W dniu 27 lutego 2010 15:51 użytkownik Michael Buesch napisał: > On Saturday 27 February 2010 12:12:23 Rafał Miłecki wrote: >> 2010/2/10 Michael Buesch : >> > On Tuesday 09 February 2010 21:04:33 Rafał Miłecki wrote: >> >> +#define B43_MMIO_PSM_PHY_HDR         0x492   /* programmable state machine */ >> > >> > The comment doesn't make a lot of sense. >> > In case you don't know, the PSM is the part of the hardware >> > that executes the firmware. >> >> Well, guess you're right. It was me hearing for the first time "PSM" >> so decided to write it. Guess it's pretty obvious for every device >> driver developer :) >> > > Well, what I wanted to say is that it's more important to explain > what PHY_HDR means. Something like /* PSM PHY header */ ? Sure, explaining HDR sounds great, but do you actually know it's header? Personally I have no idea, so I am not sure if you know that with nice probability of being right, or are you just guessing? :) -- Rafał