Return-path: Received: from fg-out-1718.google.com ([72.14.220.157]:46331 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343Ab0BEQvD convert rfc822-to-8bit (ORCPT ); Fri, 5 Feb 2010 11:51:03 -0500 Received: by fg-out-1718.google.com with SMTP id 22so14298fge.1 for ; Fri, 05 Feb 2010 08:51:02 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <4B6B8F8B.6020908@lwfinger.net> References: <1265317065-2922-2-git-send-email-zajec5@gmail.com> <4B6B8F8B.6020908@lwfinger.net> From: =?ISO-8859-1?Q?G=E1bor_Stefanik?= Date: Fri, 5 Feb 2010 17:41:00 +0100 Message-ID: <69e28c911002050841x20053c6jbe768c19e983ef50@mail.gmail.com> Subject: Re: [RFC][PATCH] b43: LP-PHY: always adjust gain table on channel switch To: Larry Finger Cc: =?ISO-8859-2?Q?Rafa=B3_Mi=B3ecki?= , linux-wireless@vger.kernel.org, "John W. Linville" , bcm43xx-dev@lists.berlios.de Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Feb 5, 2010 at 4:24 AM, Larry Finger wrote: > On 02/04/2010 02:57 PM, Rafał Miłecki wrote: >> --- >> Gábor: I think you missed specs here. Could you check whole routine just for >> sure, please? I don't understand whole radio and chanspec magic yet. >> --- >>  drivers/net/wireless/b43/phy_lp.c |    2 +- >>  1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c >> index 185219e..61009ee 100644 >> --- a/drivers/net/wireless/b43/phy_lp.c >> +++ b/drivers/net/wireless/b43/phy_lp.c >> @@ -2655,8 +2655,8 @@ static int b43_lpphy_op_switch_channel(struct b43_wldev *dev, >>               if (err) >>                       return err; >>               lpphy_set_analog_filter(dev, new_channel); >> -             lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); >>       } >> +     lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); >> >>       lpphy->channel = new_channel; >>       b43_write16(dev, B43_MMIO_CHANNEL, new_channel); > > Both the lpphy_set_analog_filter() and lpphy_adjust_gain_table() calls should be > outside the if statement. I changed the spec a little. It used to test "radio > enabled", but I have found that is always true for our driver. > > Larry > > Isn't set_analog_filter() rev0/1-specific? -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)