Return-path: Received: from ist.d-labs.de ([213.239.218.44]:56824 "EHLO mx01.d-labs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755087Ab0BTXHS (ORCPT ); Sat, 20 Feb 2010 18:07:18 -0500 Date: Sun, 21 Feb 2010 00:07:16 +0100 From: Florian Mickler To: Johannes Berg Cc: linux-wireless@vger.kernel.org, Randy Dunlap , "John W. Linville" , Alan Jenkins , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 2/2] enhance /sys/class/rfkill//state interface Message-ID: <20100221000716.29ad3e90@schatten.dmk.lab> In-Reply-To: <1266704090.10980.0.camel@jlt3.sipsolutions.net> References: <1266702045-6062-1-git-send-email-florian@mickler.org> <1266702045-6062-3-git-send-email-florian@mickler.org> <1266704090.10980.0.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, 20 Feb 2010 23:14:48 +0100 Johannes Berg wrote: > On Sat, 2010-02-20 at 22:40 +0100, florian@mickler.org wrote: > > Introduce a new state-value RFKILL_STATE_SOFT_AND_HARD_BLOCKED > > which is returned only through the sysfs state file. > > The other interfaces are designed so that they don't need this extra > > state. > > > > This allows the sysfs to represent all possible states an rfkill > > driver can > > have. > > > > Signed-off-by: Florian Mickler > > --- > > > > After stumbling over this arbitrary limitation of > > sys/class/rfkill/*/state I > > wondered what would hinder this patch? > > This is not backward compatible, so can't be done. > > johannes hmm... ah, i see... if driver is in hard'n'soft-block state an userspace program would expect to read hardblock instead of the new hard'n'softblock-state... now that i think of it, it even becomes obvious :) cheers, Flo