Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:38353 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755290Ab0CQQUW (ORCPT ); Wed, 17 Mar 2010 12:20:22 -0400 Subject: Re: [RFC PATCHv3 2/2] mac80211: Add support for connection quality monitoring From: Johannes Berg To: Juuso Oikarinen Cc: linux-wireless@vger.kernel.org In-Reply-To: <1268830877-5162-3-git-send-email-juuso.oikarinen@nokia.com> References: <1268830877-5162-1-git-send-email-juuso.oikarinen@nokia.com> <1268830877-5162-3-git-send-email-juuso.oikarinen@nokia.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 17 Mar 2010 09:20:21 -0700 Message-ID: <1268842821.5989.18.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2010-03-17 at 15:01 +0200, Juuso Oikarinen wrote: > +void ieee80211_cqm_notify(struct ieee80211_vif *vif, > + enum nl80211_cqm_state rssi_state) > +{ > + struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif); > + > + cfg80211_cqm_notify(sdata->dev, rssi_state, GFP_KERNEL); > +} > +EXPORT_SYMBOL(ieee80211_cqm_notify); How do you know GFP_KERNEL is OK? The driver might call this from an interrupt? Seems better to me to ask the driver for the allocation flags too. johannes