Return-path: Received: from mail.atheros.com ([12.36.123.2]:35128 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751888Ab0CQA4F convert rfc822-to-8bit (ORCPT ); Tue, 16 Mar 2010 20:56:05 -0400 Received: from mail.atheros.com ([10.10.20.105]) by sidewinder.atheros.com for ; Tue, 16 Mar 2010 17:56:05 -0700 Date: Tue, 16 Mar 2010 17:54:50 +0530 From: Senthil Balasubramanian To: "John W. Linville" CC: Senthilkumar Balasubramanian , "linux-wireless@vger.kernel.org" , Jiri Slaby , "Luis R. Rodriguez" Subject: Re: [PATCH] wireless: convert reg_regdb_search_lock to mutex Message-ID: <20100316122449.GA17826@senthil-lnx.users.atheros.com> References: <4B9F86E9.2030702@gmail.com> <1268768940-5654-1-git-send-email-linville@tuxdriver.com> <20100316100337.GA1732@senthil-lnx.users.atheros.com> <20100317002416.GA2095@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" In-Reply-To: <20100317002416.GA2095@tuxdriver.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Mar 17, 2010 at 05:54:16AM +0530, John W. Linville wrote: > On Tue, Mar 16, 2010 at 03:33:38PM +0530, Senthil Balasubramanian wrote: > > On Wed, Mar 17, 2010 at 01:19:00AM +0530, John W. Linville wrote: > > > Stanse discovered that kmalloc can be called with GFP_KERNEL while > > This commit log is confusing. It Should be "Stanse discovered kmalloc > > was called with GFP_KERNEL". Obviously kmalloc with GFP_KERNEL shouldn't > > be used while holding a spinlock. > > > holding this spinlock. It can be a mutex instead. > > Not half so confusing as your criticism... :-) sorry! if my mail wasn't proper. I didn't meant to blame/criticize. I was confused when I read the commit log and so I replied. > > Are you objecting to "can be" instead of "was"? I am not objecting anything... > > John > -- > John W. Linville ? ? ? ? ? ? ? ?Someday the world will need a hero, and you > linville@tuxdriver.com ? ? ? ? ? ? ? ? ?might be all we have. ?Be ready.