Return-path: Received: from fg-out-1718.google.com ([72.14.220.155]:40792 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754483Ab0CVNkt convert rfc822-to-8bit (ORCPT ); Mon, 22 Mar 2010 09:40:49 -0400 MIME-Version: 1.0 In-Reply-To: <20100322115244.GA10368@zooey> References: <20100322115244.GA10368@zooey> From: =?ISO-8859-1?Q?G=E1bor_Stefanik?= Date: Mon, 22 Mar 2010 14:40:27 +0100 Message-ID: <69e28c911003220640t77d01dccod8232ea007257a5f@mail.gmail.com> Subject: Re: [PATCH] drivers/net/wireless/b43/main.c:4351: Fixed coding style To: Daniel Ngu Cc: Stefano Brivio , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Mar 22, 2010 at 12:52 PM, Daniel Ngu wrote: > WARNING: braces {} are not necessary for any arm of this statement > > Signed-off-by: Daniel Ngu > --- > ?drivers/net/wireless/b43/main.c | ? ?5 ++--- > ?1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c > index 1521b1e..14cf3bd 100644 > --- a/drivers/net/wireless/b43/main.c > +++ b/drivers/net/wireless/b43/main.c > @@ -4348,11 +4348,10 @@ static int b43_wireless_core_init(struct b43_wldev *dev) > ? ? ? ?b43_set_phytxctl_defaults(dev); > > ? ? ? ?/* Minimum Contention Window */ > - ? ? ? if (phy->type == B43_PHYTYPE_B) { > + ? ? ? if (phy->type == B43_PHYTYPE_B) > ? ? ? ? ? ? ? ?b43_shm_write16(dev, B43_SHM_SCRATCH, B43_SHM_SC_MINCONT, 0x1F); > - ? ? ? } else { > + ? ? ? else > ? ? ? ? ? ? ? ?b43_shm_write16(dev, B43_SHM_SCRATCH, B43_SHM_SC_MINCONT, 0xF); > - ? ? ? } > ? ? ? ?/* Maximum Contention Window */ > ? ? ? ?b43_shm_write16(dev, B43_SHM_SCRATCH, B43_SHM_SC_MAXCONT, 0x3FF); > > -- > 1.5.6.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at ?http://vger.kernel.org/majordomo-info.html > Actually I believe the entire PHYTYPE_B brahcn could be removed, as we no longer have B-PHY support in b43 anyway. But consult Michael about this. -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)