Return-path: Received: from fg-out-1718.google.com ([72.14.220.158]:62473 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753208Ab0CBWLO (ORCPT ); Tue, 2 Mar 2010 17:11:14 -0500 Received: by fg-out-1718.google.com with SMTP id 16so339600fgg.1 for ; Tue, 02 Mar 2010 14:11:12 -0800 (PST) Message-ID: <4B8D8CF8.8030003@lwfinger.net> Date: Tue, 02 Mar 2010 16:11:04 -0600 From: Larry Finger MIME-Version: 1.0 To: Michael Buesch CC: Nathan Schulte , =?ISO-8859-1?Q?G=E1bor_Stefanik?= , bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org, Linus Torvalds Subject: Re: LP-PHY Fatal DMA error 0x00000800 on non-ULV Core 2 Duo?!?!!??! References: <69e28c911002260708g45d3c0f7u6abf13b1babe549f@mail.gmail.com> <201003010122.51341.mb@bu3sch.de> <201003022257.51878.mb@bu3sch.de> In-Reply-To: <201003022257.51878.mb@bu3sch.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 03/02/2010 03:57 PM, Michael Buesch wrote: > > So what's the status on this? I think the fact that the testing patch showed some > improvement is a clear indicator that something in the PCI-E core init is wrong. > It's also not surprising that something is going wrong there. The whole PCI-E core > code basically is undebugged. I wrote most of it long time ago, but I still > don't have a device that tests it (and probably won't get one anytime soon). > So I'm really not surprised that there are bugs. There also are missing parts. > > A bug in the PCI-E core code is able to show such behavior, because all memory > transfers (MMIO and DMA) from the PCI device to the wireless core are translated > by the PCI-E core. > I think the whole PCI-E core code has to be audited (also the specs, probably). You are right about the audit of the PCIe code and specs. Some of the MMIO sequences found for wl and missing in b43 come from the code described in http://bcm-v4.sipsolutions.net/PCI-E; however, that code needs to be checked as at least one routine is missing, I have not yet had a chance to go through it, but I hope to soon. Larry