Date: Fri, 12 Mar 2010 21:57:43 +0100
From: Florian Mickler <florian@mickler.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	Marcel Holtmann <marcel@holtmann.org>,
	Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org,
	Randy Dunlap <rdunlap@xenotime.net>,
	Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] enhance sysfs rfkill interface
Message-ID: <20100312215743.7671d173@schatten.dmk.lab>
In-Reply-To: <20100312182209.GB8736@core.coreip.homeip.net>
References: <1268416988-24862-1-git-send-email-florian@mickler.org>
	<1268416988-24862-2-git-send-email-florian@mickler.org>
	<1268416988-24862-3-git-send-email-florian@mickler.org>
	<20100312182209.GB8736@core.coreip.homeip.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-wireless-owner@vger.kernel.org

On Fri, 12 Mar 2010 10:22:09 -0800
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

> On Fri, Mar 12, 2010 at 07:03:08PM +0100, florian@mickler.org wrote:
> >  
> > +static ssize_t rfkill_hard_show(struct device *dev,
> > +				 struct device_attribute *attr,
> > +				 char *buf)
> > +{
> > +	struct rfkill *rfkill = to_rfkill(dev);
> > +	unsigned long flags;
> > +	u32 state;
> > +
> > +	spin_lock_irqsave(&rfkill->lock, flags);
> > +	state = rfkill->state;
> > +	spin_unlock_irqrestore(&rfkill->lock, flags);
> 
> Why exactly is this lock needed?

The rfkill state is updated from multiple contexts... Am I overlooking
smth obvious here?

cheers,
Flo