Date: Mon, 29 Mar 2010 11:04:04 +0900
To: ben@decadent.org.uk
Cc: fujita.tomonori@lab.ntt.co.jp, bzolnier@gmail.com, gregkh@suse.de,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rt28xx: Make PCI_{MAP,UNMAP}_SINGLE type-safe
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
In-Reply-To: <1269827928.8653.307.camel@localhost>
References: <1269822285.8653.251.camel@localhost>
	<20100329105129Y.fujita.tomonori@lab.ntt.co.jp>
	<1269827928.8653.307.camel@localhost>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Message-Id: <20100329110339P.fujita.tomonori@lab.ntt.co.jp>
Sender: linux-wireless-owner@vger.kernel.org

On Mon, 29 Mar 2010 02:58:48 +0100
Ben Hutchings <ben@decadent.org.uk> wrote:

> On Mon, 2010-03-29 at 10:52 +0900, FUJITA Tomonori wrote:
> > On Mon, 29 Mar 2010 01:24:45 +0100
> > Ben Hutchings <ben@decadent.org.uk> wrote:
> > 
> > > To avoid recurrence of bugs such as <http://bugs.debian.org/575726>,
> > > change the type of the first parameter to linux_pci_{map,unmap}_single()
> > > from void * to struct rt_rtmp_adapter *.  Also do not define the macros
> > > PCI_{MAP,UNMAP}_SINGLE() when building the rt2870sta driver; they are
> > > not used and if they were that would be a bug.
> > > 
> > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk> 
> > > ---
> > >  drivers/staging/rt2860/rt_linux.h    |   14 +++++---------
> > >  drivers/staging/rt2860/rt_pci_rbus.c |   12 ++++--------
> > >  2 files changed, 9 insertions(+), 17 deletions(-)
> > 
> > I think using dma_map_single directly instead of inventing a wrapper
> > function make the code more readable.
> 
> These functions are not quite simple wrappers, unfortunately.  So while
> I think that is worth doing it is a separate change.

Well, the current wrapper functions looks terrible. Needs to fix them
before moving the driver out of the staging anyway, I think.