Return-path: Received: from c60.cesmail.net ([216.154.195.49]:39501 "EHLO c60.cesmail.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704Ab0CRRMS (ORCPT ); Thu, 18 Mar 2010 13:12:18 -0400 Subject: Re: [PATCH v2 7/7] wireless.h: Use SIOCIWFIRST not SIOCSIWCOMMIT for range check From: Pavel Roskin To: Joe Perches Cc: linux-kernel@vger.kernel.org, Richard Kennedy , Johannes Berg , "John W. Linville" , linux-wireless@vger.kernel.org In-Reply-To: References: Content-Type: text/plain Date: Thu, 18 Mar 2010 13:12:16 -0400 Message-Id: <1268932336.24544.6.camel@mj> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2010-03-17 at 23:21 -0700, Joe Perches wrote: > These two #defines use the same value, but > SIOCIWFIRST makes more sense in this use. Agreed. Also please change a comment referring to SIOCSIWCOMMIT in include/net/iw_handler.h It would be great if you don't copy LKML next time. It's a purely wireless issues. I don't like having a dilemma between cross-posting and trimming the recipient list. -- Regards, Pavel Roskin