Return-path: Received: from mail-qy0-f179.google.com ([209.85.221.179]:59353 "EHLO mail-qy0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756659Ab0D0Tfv (ORCPT ); Tue, 27 Apr 2010 15:35:51 -0400 Received: by qyk9 with SMTP id 9so19868449qyk.1 for ; Tue, 27 Apr 2010 12:35:50 -0700 (PDT) MIME-Version: 1.0 Date: Tue, 27 Apr 2010 12:35:48 -0700 Message-ID: Subject: libertas sdio broken on XO-1.5s From: Steve deRosier To: linux-wireless@vger.kernel.org, Dan Williams Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Dan, A change made by you on April 15th breaks firmware downloading to an sdio connected 8686 on the OLPC's XO-1.5s. I reverted it and was able to get firmware to load just fine, with it in, the firmware fails to load. commit 96021f096e5178582af296a2fbb6df7dbd6b695c Author: Dan Williams Date: Thu Apr 15 13:27:44 2010 -0700 libertas: consolidate SDIO firmware wait code Consolidate a bunch of C&P code that waits for the firmware to be ready. Signed-off-by: Dan Williams Signed-off-by: John W. Linville dmesg: [ 15.391242] libertas_sdio: Libertas SDIO driver [ 15.391255] libertas_sdio: Copyright Pierre Ossman [ 15.539475] libertas_sdio mmc0:0001:1: firmware: requesting sd8686_helper.bin [ 17.540214] libertas: failed to load helper firmware [ 17.541054] libertas_sdio: probe of mmc0:0001:1 failed with error -110 dmesg with it reverted: [ 15.141728] libertas_sdio: Libertas SDIO driver [ 15.141741] libertas_sdio: Copyright Pierre Ossman [ 15.275322] libertas_sdio mmc0:0001:1: firmware: requesting sd8686_helper.bin [ 16.430223] libertas_sdio mmc0:0001:1: firmware: requesting sd8686.bin [ 17.172443] libertas: 00:50:43:28:26:40, fw 9.70.7p0, cap 0x00000303 [ 17.179552] libertas: wlan0: Marvell WLAN 802.11 adapter I don't know if there's something unique with this device where libertas_sdio works everywhere else and not with the XO-1.5, but I suspect we'll encounter this issue with other libertas devices. I apologize for not sending a patch, but I don't have time right now to get to it. Perhaps you can get to it quicker, if so, I'll be happy to test anything you come up with. - Steve