Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:50720 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933416Ab0D3SWz (ORCPT ); Fri, 30 Apr 2010 14:22:55 -0400 Received: by vws19 with SMTP id 19so426678vws.19 for ; Fri, 30 Apr 2010 11:22:52 -0700 (PDT) Date: Thu, 29 Apr 2010 11:29:57 +0200 From: Dan Carpenter To: Zhu Yi Cc: "Ortiz, Samuel" , Intel Linux Wireless , "John W. Linville" , Andrew Morton , Alexey Dobriyan , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [patch] iwl: cleanup: remove unneeded error handling Message-ID: <20100429092956.GH29093@bicker> References: <20100428090115.GF29093@bicker> <1272507134.14773.4339.camel@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1272507134.14773.4339.camel@debian> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Apr 29, 2010 at 10:12:14AM +0800, Zhu Yi wrote: > > Thanks. But looks like you missed the one in if_sdio_debugfs_init(). > Yup. > I don't think we even need to check -ENODEV ourselves because if > DEBUG_FS is not compiled in, all the debugfs utility functions will > become no-op. > Good point. > Signed-off-by: Dan Carpenter Probably this could get changed to just "Reported-by" but I'm happy to take credit for other peoples work. :) > Signed-off-by: Zhu Yi > Acked-by: Dan Carpenter regards, dan carpenter