Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:42577 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752619Ab0DFAI3 convert rfc822-to-8bit (ORCPT ); Mon, 5 Apr 2010 20:08:29 -0400 Received: by pwj9 with SMTP id 9so776870pwj.19 for ; Mon, 05 Apr 2010 17:08:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <40101cc31003200759u447b625ct6f48aa6003593dac@mail.gmail.com> From: "Luis R. Rodriguez" Date: Mon, 5 Apr 2010 17:08:09 -0700 Message-ID: Subject: Re: Compat wireless with kernel 2.6.33 To: Matteo Croce Cc: linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Apr 5, 2010 at 4:54 PM, Matteo Croce wrote: > On Tue, Apr 6, 2010 at 1:34 AM, Luis R. Rodriguez wrote: >> On Sat, Mar 20, 2010 at 7:59 AM, Matteo Croce wrote: >>> This patch allows compat wireless to compile with a kernel >= 2.6.33 >>> >>> Index: compat-wireless-2010-03-19/scripts/gen-compat-autoconf.sh >>> =================================================================== >>> --- compat-wireless-2010-03-19.orig/scripts/gen-compat-autoconf.sh      2010-03-20 >>> 15:26:22.604720545 +0100 >>> +++ compat-wireless-2010-03-19/scripts/gen-compat-autoconf.sh   2010-03-20 >>> 15:27:49.212236531 +0100 >>> @@ -145,7 +145,11 @@ >>>  kernel_version_req $OLDEST_KERNEL_SUPPORTED >>> >>>  # Handle core kernel wireless depenencies here >>> +echo '#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,33)' >>> +define_config_req CONFIG_CFG80211_WEXT >>> +echo '#else' >>>  define_config_req CONFIG_WIRELESS_EXT >>> +echo '#endif' >>> >>>  # For each CONFIG_FOO=x option >>>  for i in $(grep '^CONFIG_' $COMPAT_CONFIG); do >> >> Sorry been meaning to reply, reason I haven't applied it is this seems >> wrong, we should be able to build kernels with 802.11 without wext >> crap on new kernels. Perhaps only add the requirement for kernels >> older than 2.6.33? >> >>  Luis >> > > Please do not disable wext until nl80211 can really replace it. wext is already disabled by default if you don't have a driver that requires it. > There are some things than nl80211 can't do yet (eg. txpower) Sure, that's the only thing I'm aware of. Luis