Return-path: Received: from fg-out-1718.google.com ([72.14.220.155]:49825 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755920Ab0DIHnB (ORCPT ); Fri, 9 Apr 2010 03:43:01 -0400 Received: by fg-out-1718.google.com with SMTP id d23so1121439fga.1 for ; Fri, 09 Apr 2010 00:42:59 -0700 (PDT) From: Helmut Schaa To: Gertjan van Wingerde Subject: Re: [PATCH 3/9] rt2x00: Align RT chipset definitions with vendor driver. Date: Fri, 9 Apr 2010 09:42:53 +0200 Cc: Felix Fietkau , "'Luis Correia'" , "John W. Linville" , Ivo van Doorn , linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com References: <1270763437-29526-1-git-send-email-gwingerde@gmail.com> <4BBEB6E1.70300@gmail.com> <4BBEBD47.9010405@gmail.com> In-Reply-To: <4BBEBD47.9010405@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Message-Id: <201004090942.53884.helmut.schaa@googlemail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: Am Freitag 09 April 2010 schrieb Gertjan van Wingerde: > On 04/09/10 07:10, Gertjan van Wingerde wrote: > > On 04/09/10 00:28, Felix Fietkau wrote: > >> On 2010-04-08 11:50 PM, Gertjan van Wingerde wrote: > >>> Only include definitions for RT chipsets that are also used inside the > >>> Ralink vendor drivers. > >>> > >>> Signed-off-by: Gertjan van Wingerde > >>> --- > >>> drivers/net/wireless/rt2x00/rt2800lib.c | 13 ------------- > >>> drivers/net/wireless/rt2x00/rt2x00.h | 7 +++---- > >>> 2 files changed, 3 insertions(+), 17 deletions(-) > >>> > >>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c > >>> index 394c8e4..4bc7e09 100644 > >>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c > >>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c > >>> @@ -1209,10 +1209,7 @@ int rt2800_init_registers(struct rt2x00_dev *rt2x00dev) > >>> rt2x00_set_field32(®, MAX_LEN_CFG_MAX_MPDU, AGGREGATION_SIZE); > >>> if ((rt2x00_rt(rt2x00dev, RT2872) && > >>> (rt2x00_rev(rt2x00dev) >= RT2880E_VERSION)) || > >>> - rt2x00_rt(rt2x00dev, RT2880) || > >>> rt2x00_rt(rt2x00dev, RT2883) || > >>> - rt2x00_rt(rt2x00dev, RT2890) || > >>> - rt2x00_rt(rt2x00dev, RT3052) || > >>> (rt2x00_rt(rt2x00dev, RT3070) && > >>> (rt2x00_rev(rt2x00dev) < RT3070_VERSION))) > >>> rt2x00_set_field32(®, MAX_LEN_CFG_MAX_PSDU, 2); > >>> @@ -1511,12 +1508,6 @@ int rt2800_init_bbp(struct rt2x00_dev *rt2x00dev) > >>> rt2800_bbp_write(rt2x00dev, 105, 0x05); > >>> } > >>> > >>> - if (rt2x00_rt(rt2x00dev, RT3052)) { > >>> - rt2800_bbp_write(rt2x00dev, 31, 0x08); > >>> - rt2800_bbp_write(rt2x00dev, 78, 0x0e); > >>> - rt2800_bbp_write(rt2x00dev, 80, 0x08); > >>> - } > >>> - > >> Why are you removing support for RT3052? IMHO those writes were > >> necessary, last time I tested the rt2800pci code on the RT3052 WiSoC. > > > > That is because I have not been able to find them in any of the Ralink vendor drivers. > > Actually, none of the Ralink vendor drivers mention an RT chipset that identifies itself > > as a RT3052. The only mentioning Ive seen is RT305x devices that identify themselves as > > RT2872 devices, but even for them I haven't found these BBP initializations. > > That's why I removed this part. > > > > I have no problem re-instating this if I can find some evidence that these devices > > actually exist. > > > > Hold on, I seem to have found something here. And there are more things to be set, according > to the code I found. However, that code is unclear with respect to how the chip identifies > itself. > > Is it possible for you to found out on you RT3052 WiSoC how the chip identifies itself > (i.e. what is the contents of the MAC_CSR0 register)? > > Helmut, Luis, I know you guys have been experimenting with WiSoC devices as well, what kind > of devices do you have, and how do these identify themselves? I've got two different devices and both use the same rt chipset 2872, one has a rf 3020 (1T1R) and the other one a rf 3022 (2T2R). Helmut