Return-path: Received: from mail-bw0-f225.google.com ([209.85.218.225]:38936 "EHLO mail-bw0-f225.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758719Ab0DVUr7 convert rfc822-to-8bit (ORCPT ); Thu, 22 Apr 2010 16:47:59 -0400 Received: by bwz25 with SMTP id 25so10166830bwz.28 for ; Thu, 22 Apr 2010 13:47:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1271944442-9214-1-git-send-email-notasas@gmail.com> <1271954537.8469.15.camel@mj> Date: Thu, 22 Apr 2010 23:47:55 +0300 Message-ID: Subject: Re: [PATCH] compat: fix uevent_suppress on 2.6.29 or older kernels From: Grazvydas Ignotas To: "Luis R. Rodriguez" Cc: Pavel Roskin , linux-wireless@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Apr 22, 2010 at 11:33 PM, Luis R. Rodriguez wrote: > On Thu, Apr 22, 2010 at 9:42 AM, Pavel Roskin wrote: >> On Thu, 2010-04-22 at 09:33 -0700, Luis R. Rodriguez wrote: >> >>> How was this compiling for older kernels before then? >> >> Compiling was fine, but loading the firmware was failing sometimes. ?I'm >> glad somebody figured it out. ?Thank you, Grazvydas! > > OK Applied. I'm still puzzled, if it compiled, then that means > dev_set_uevent_suppress() was being defined somehow for older kernels. there was already ifdef, old code: #if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,30)) dev_set_uevent_suppress(f_dev, 1); #endif new code: #if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,30)) dev_set_uevent_suppress(f_dev, 1); #else f_dev->uevent_suppress = 1; #endif >> I would prefer to have replacement functions in compat-2.6.30.h rather >> than ifdefs in the code. ?We might want to resync compat_firmware with >> the kernel one day, and ifdefs would stand in the way. > > Good point, I merged the patch for now given that that file does't > change that often upstream. > > ?Luis >