Return-path: Received: from mail-gw0-f46.google.com ([74.125.83.46]:47467 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753076Ab0EZVsF convert rfc822-to-8bit (ORCPT ); Wed, 26 May 2010 17:48:05 -0400 Received: by gwaa12 with SMTP id a12so1318048gwa.19 for ; Wed, 26 May 2010 14:48:03 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Weedy Date: Wed, 26 May 2010 17:47:39 -0400 Message-ID: Subject: Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite) To: Bob Copeland Cc: =?UTF-8?Q?G=C3=A1bor_Stefanik?= , linux-wireless , Johannes Berg Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2010/5/26 Bob Copeland : > 2010/5/25 Gábor Stefanik : >> On Tue, May 25, 2010 at 4:53 PM, Bob Copeland wrote: >>> 2010/5/25 Weedy : >>>> 2010/5/24 Gábor Stefanik : >>>>> 2010/5/25 Weedy : >>>>>> 2010/5/23 Gábor Stefanik : >>>>>>> In the meantime, one thing to test: Add a printk of sc->opmode. >>>>>> >>>>>> May 24 22:04:20 tiny-h4x kernel: [41147.243149] sc->opmode: 02 (over9000 times) >>>>>> >>>>>> So i'm guessing I did it wrong (I don't know C). >>>>>>        printk(KERN_NOTICE "sc->opmode: %02x\n", sc->opmode); >>>>>> >>>>> >>>>> No, that is correct, and proves my theory (2 is NL80211_IFTYPE_STATION >>>>> - it should be 6 for monitor mode). >>>>> >>>>> BTW, please use "Reply to all". >>>>> >>>> gmail got rid of the "Reply to all by default" option :< >>>> >>>> When you have a patch I will be waiting. >>> >>> Sorry, I missed this thread somehow.  Thanks for the detective >>> work and apologies for my stupid goof.  Gábor, are you prepping >>> a patch?  I can fix it if you like. >>> >> >> If you can, please fix it - I know what the bug is, but have no solid >> idea about a fix. > > Ok, it should be enough to look at the filter flags instead of > the opmode -- I knew in the back of my mind that the monitor > stuff was bogus (part of the reason I did the patch in the first > place) but just got confused by what was already there I guess. > > I await your patch with open arms.