Return-path: Received: from mail-qy0-f183.google.com ([209.85.221.183]:43389 "EHLO mail-qy0-f183.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754936Ab0EZMnt convert rfc822-to-8bit (ORCPT ); Wed, 26 May 2010 08:43:49 -0400 Received: by qyk13 with SMTP id 13so9009344qyk.1 for ; Wed, 26 May 2010 05:43:48 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 26 May 2010 08:43:48 -0400 Message-ID: Subject: Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite) From: Bob Copeland To: =?ISO-8859-1?Q?G=E1bor_Stefanik?= Cc: Weedy , linux-wireless , Johannes Berg Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2010/5/25 G?bor Stefanik : > On Tue, May 25, 2010 at 4:53 PM, Bob Copeland wrote: >> 2010/5/25 Weedy : >>> 2010/5/24 G?bor Stefanik : >>>> 2010/5/25 Weedy : >>>>> 2010/5/23 G?bor Stefanik : >>>>>> In the meantime, one thing to test: Add a printk of sc->opmode. >>>>> >>>>> May 24 22:04:20 tiny-h4x kernel: [41147.243149] sc->opmode: 02 (over9000 times) >>>>> >>>>> So i'm guessing I did it wrong (I don't know C). >>>>> ? ? ? ?printk(KERN_NOTICE "sc->opmode: %02x\n", sc->opmode); >>>>> >>>> >>>> No, that is correct, and proves my theory (2 is NL80211_IFTYPE_STATION >>>> - it should be 6 for monitor mode). >>>> >>>> BTW, please use "Reply to all". >>>> >>> gmail got rid of the "Reply to all by default" option :< >>> >>> When you have a patch I will be waiting. >> >> Sorry, I missed this thread somehow. ?Thanks for the detective >> work and apologies for my stupid goof. ?G?bor, are you prepping >> a patch? ?I can fix it if you like. >> > > If you can, please fix it - I know what the bug is, but have no solid > idea about a fix. Ok, it should be enough to look at the filter flags instead of the opmode -- I knew in the back of my mind that the monitor stuff was bogus (part of the reason I did the patch in the first place) but just got confused by what was already there I guess. -- Bob Copeland %% www.bobcopeland.com