Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:52421 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753776Ab0EARTp convert rfc822-to-8bit (ORCPT ); Sat, 1 May 2010 13:19:45 -0400 Received: by mail-fx0-f46.google.com with SMTP id 10so1056805fxm.19 for ; Sat, 01 May 2010 10:19:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <4BDC56D2.5060605@gmail.com> <201005011907.05603.mb@bu3sch.de> From: =?ISO-8859-1?Q?G=E1bor_Stefanik?= Date: Sat, 1 May 2010 19:19:24 +0200 Message-ID: Subject: Re: [PATCH] ssb: Implement fast powerup delay calculation To: Michael Buesch Cc: "John W. Linville" , linux-wireless , b43-dev , Larry Finger Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2010/5/1 G?bor Stefanik : > 2010/5/1 Michael Buesch : >> On Saturday 01 May 2010 18:29:06 G?bor Stefanik wrote: >>> + ? ? ssb_write16(cc->dev, SSB_MMIO_POWERUP_DELAY, delay); >>> ? } >>> >>> ? void ssb_chipco_suspend(struct ssb_chipcommon *cc) >>> Index: wireless-testing/include/linux/ssb/ssb_regs.h >>> =================================================================== >>> --- wireless-testing.orig/include/linux/ssb/ssb_regs.h >>> +++ wireless-testing/include/linux/ssb/ssb_regs.h >>> @@ -26,6 +26,7 @@ >>> ? #define ? ? SSB_EUART ? ? ? ? ? ? ? (SSB_EXTIF_BASE + 0x00800000) >>> ? #define ? ? SSB_LED ? ? ? ? ? ? ? ? (SSB_EXTIF_BASE + 0x00900000) >>> >>> +#define SSB_MMIO_POWERUP_DELAY ? ? ? 0x06A8 >> >> I think you are really confusing something here. >> That register is a wireless core register and we already write it in b43. >> >> -- >> Greetings, Michael. >> > > This is what I am implementing: http://bcm-v4.sipsolutions.net/802.11/Init > Here, it clearly says MMIO offset. > > -- > Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) > Sorry, now I understand. The MMIO write is unnecessary. -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)