Return-path: Received: from fg-out-1718.google.com ([72.14.220.155]:50569 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755302Ab0ECVKf convert rfc822-to-8bit (ORCPT ); Mon, 3 May 2010 17:10:35 -0400 Received: by fg-out-1718.google.com with SMTP id d23so1252331fga.1 for ; Mon, 03 May 2010 14:10:33 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1272920504.4907.5.camel@mj> References: <1272907549-25847-1-git-send-email-linville@tuxdriver.com> <87k4rkk9tz.fsf@purkki.valot.fi> <1272920504.4907.5.camel@mj> Date: Mon, 3 May 2010 23:10:33 +0200 Message-ID: Subject: Re: [PATCH] iwlagn: Change the TPT calculations sanity-check to WARN_ON From: Adel Gadllah To: Pavel Roskin Cc: =?ISO-8859-1?Q?G=E1bor_Stefanik?= , Kalle Valo , "John W. Linville" , linux-wireless@vger.kernel.org, johill@sipsolutions.net, reinette.chatre@intel.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2010/5/3 Pavel Roskin : > On Mon, 2010-05-03 at 22:48 +0200, G?bor Stefanik wrote: > >> One exception I can think of: major misconfiguration can cause a >> wireless device to DMA data into sensitive memory locations. When >> evidence of this is detected, it might make sense to BUG_ON() >> (especially if the bogus DMA operations can be exploited remotely to >> overwrite arbitrary memory addresses). However, in that case, the >> attacker may have already overwritten panic() with malicious code as >> well, so even this case doesn't hold. > > And then there is a case when encryption fails and there is a risk of > transmitting data without encryption or accepting data without > verification. So kill the connection rather than the whole system.