Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:34242 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753707Ab0E0Dth (ORCPT ); Wed, 26 May 2010 23:49:37 -0400 Received: by vws9 with SMTP id 9so4964957vws.19 for ; Wed, 26 May 2010 20:49:36 -0700 (PDT) Message-ID: <4BFDEBDC.4070304@gmail.com> Date: Wed, 26 May 2010 23:49:48 -0400 From: Richard Farina MIME-Version: 1.0 To: Bob Copeland CC: =?ISO-8859-1?Q?G=E1bor_Stefanik?= , Weedy , linux-wireless , Johannes Berg Subject: Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite) References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Bob Copeland wrote: > 2010/5/25 G?bor Stefanik : > >> On Tue, May 25, 2010 at 4:53 PM, Bob Copeland wrote: >> >>> 2010/5/25 Weedy : >>> >>>> 2010/5/24 G?bor Stefanik : >>>> >>>>> 2010/5/25 Weedy : >>>>> >>>>>> 2010/5/23 G?bor Stefanik : >>>>>> >>>>>>> In the meantime, one thing to test: Add a printk of sc->opmode. >>>>>>> >>>>>> May 24 22:04:20 tiny-h4x kernel: [41147.243149] sc->opmode: 02 (over9000 times) >>>>>> >>>>>> So i'm guessing I did it wrong (I don't know C). >>>>>> printk(KERN_NOTICE "sc->opmode: %02x\n", sc->opmode); >>>>>> >>>>>> >>>>> No, that is correct, and proves my theory (2 is NL80211_IFTYPE_STATION >>>>> - it should be 6 for monitor mode). >>>>> >>>>> BTW, please use "Reply to all". >>>>> >>>>> >>>> gmail got rid of the "Reply to all by default" option :< >>>> >>>> When you have a patch I will be waiting. >>>> >>> Sorry, I missed this thread somehow. Thanks for the detective >>> work and apologies for my stupid goof. G?bor, are you prepping >>> a patch? I can fix it if you like. >>> >>> >> If you can, please fix it - I know what the bug is, but have no solid >> idea about a fix. >> > > Ok, it should be enough to look at the filter flags instead of > the opmode -- I knew in the back of my mind that the monitor > stuff was bogus (part of the reason I did the patch in the first > place) but just got confused by what was already there I guess. > > I've got a lot of people very interested in this fix. Let me know what kind of support you need to make this happen. You know where to find me on irc ;-) Thanks, Rick