Return-path: Received: from smtp3-g21.free.fr ([212.27.42.3]:55123 "EHLO smtp3-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752853Ab0EBUFa (ORCPT ); Sun, 2 May 2010 16:05:30 -0400 Message-ID: <4BDDDB00.90207@free.fr> Date: Sun, 02 May 2010 22:05:20 +0200 From: Benoit Papillault MIME-Version: 1.0 To: Johannes Berg CC: linux-wireless@vger.kernel.org Subject: Re: [RFC] ibss: Added channel type in order to create HT IBSS References: <1272809528-11000-1-git-send-email-benoit.papillault@free.fr> <1272817974.31265.0.camel@jlt3.sipsolutions.net> In-Reply-To: <1272817974.31265.0.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Le 02/05/2010 18:32, Johannes Berg a écrit : > On Sun, 2010-05-02 at 16:12 +0200, Benoit Papillault wrote: >> When joining an IBSS, the parameters can be used to create the IBSS. As >> such, we need to know if the user wants to create an HT IBSS or not. >> This is accomplish by passing the channel type (ie ht20, ht40- or >> ht40+). Default is to create a non HT IBSS. >> >> Signed-off-by: Benoit Papillault >> --- >> It is needed for upcoming patches regarding HT IBSS >> ibss.c | 27 ++++++++++++++++++++++++++- >> 1 files changed, 26 insertions(+), 1 deletions(-) >> >> diff --git a/ibss.c b/ibss.c >> index 4715ac8..4003a38 100644 >> --- a/ibss.c >> +++ b/ibss.c >> @@ -18,6 +18,15 @@ static int join_ibss(struct nl80211_state *state, >> { >> char *end; >> unsigned char abssid[6]; >> + int i; >> + static const struct { >> + const char *name; >> + unsigned int val; >> + } htmap[] = { >> + { .name = "HT20", .val = NL80211_CHAN_HT20, }, >> + { .name = "HT40+", .val = NL80211_CHAN_HT40PLUS, }, >> + { .name = "HT40-", .val = NL80211_CHAN_HT40MINUS, }, >> + }; > > There's code to do something like this already when setting the channel, > please factor it out and use it in both places. > > johannes > Agreed. I did a copy/paste in the hurry, my bad. I am going to post an update ASAP. Regards, Benoit