Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:44564 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833Ab0FVQwp (ORCPT ); Tue, 22 Jun 2010 12:52:45 -0400 Date: Tue, 22 Jun 2010 17:52:13 +0100 From: Matthew Garrett To: "Luis R. Rodriguez" Cc: Jussi Kivilinna , Maxim Levitsky , David Quan , Bob Copeland , "Luis R. Rodriguez" , ath5k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org, linux-kernel Subject: Re: [ath5k-devel] [PATCH v2] ath5k: disable ASPM Message-ID: <20100622165213.GA21842@srcf.ucam.org> References: <1276870309.23783.3.camel@maxim-laptop> <1276933774.16697.11.camel@maxim-laptop> <1277032723.9555.12.camel@maxim-laptop> <1277151410.5409.33.camel@maxim-laptop> <20100621233333.21262abjfxl8j1xc@hayate.sektori.org> <20100622163138.GD20668@srcf.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Jun 22, 2010 at 09:48:40AM -0700, Luis R. Rodriguez wrote: > Sure, I agree with that, but it also will enable ASPM for *all* > devices which have the capability which IMHO is a terrible idea for > users when all they want to do is enable ASPM for one device. Instead > I recommend users to enable ASPM for their devices selectively and > from userspace. Why would you only want to enable ASPM for one device? -- Matthew Garrett | mjg59@srcf.ucam.org